Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 21 additions & 24 deletions test/sequential/test-gc-http-client-onerror.js
Original file line number Diff line number Diff line change
@@ -1,37 +1,35 @@
'use strict';
// Flags: --expose-gc
// just like test-gc-http-client.js,
// but with an on('error') handler that does nothing.
// but with an on('error') handler that rethrows.

const common = require('../common');
const { onGC } = require('../common/gc');

const cpus = require('os').availableParallelism();

function serverHandler(req, res) {
req.resume();
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.end('Hello World\n');
}

const http = require('http');
const numRequests = 36;
let createClients = true;
let done = 0;
// Keep the number of in-flight requests small and fixed. Opening too many
// connections at once can overflow the listen queue (capped at 128 on macOS),
// and the kernel then resets connections that are still being established.
const concurrency = 8;
const numRequests = 64;
let count = 0;
let done = 0;
let countGC = 0;

const server = http.createServer(serverHandler);
server.listen(0, common.mustCall(() => {
for (let i = 0; i < cpus; i++)
getAll(numRequests);
for (let i = 0; i < concurrency; i++)
getNext();
}));

function getAll(requestsRemaining) {
if (!createClients)
return;

if (requestsRemaining <= 0)
function getNext() {
if (count >= numRequests)
return;

const req = http.get({
Expand All @@ -42,13 +40,14 @@ function getAll(requestsRemaining) {

count++;
onGC(req, { ongc });

setImmediate(getAll, requestsRemaining - 1);
}

function cb(res) {
res.resume();
done++;
res.on('end', () => {
done++;
getNext();
});
}

function onerror(err) {
Expand All @@ -62,16 +61,14 @@ function ongc() {
setImmediate(status);

function status() {
if (done > 0) {
createClients = false;
if (done === numRequests) {
global.gc();
console.log(`done/collected/total: ${done}/${countGC}/${count}`);
if (countGC === count) {
console.log(`done/collected/total: ${done}/${countGC}/${numRequests}`);
if (countGC === numRequests) {
server.close();
} else {
setImmediate(status);
return;
}
} else {
setImmediate(status);
}

setImmediate(status);
}
43 changes: 20 additions & 23 deletions test/sequential/test-gc-http-client.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,29 @@
const common = require('../common');
const { onGC } = require('../common/gc');

const cpus = require('os').availableParallelism();

function serverHandler(req, res) {
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.end('Hello World\n');
}

const http = require('http');
const numRequests = 36;
let createClients = true;
let done = 0;
// Keep the number of in-flight requests small and fixed. Opening too many
// connections at once can overflow the listen queue (capped at 128 on macOS),
// and the kernel then resets connections that are still being established.
const concurrency = 8;
const numRequests = 64;
let count = 0;
let done = 0;
let countGC = 0;

const server = http.createServer(serverHandler);
server.listen(0, common.mustCall(() => {
for (let i = 0; i < cpus; i++)
getAll(numRequests);
for (let i = 0; i < concurrency; i++)
getNext();
}));

function getAll(requestsRemaining) {
if (!createClients)
return;

if (requestsRemaining <= 0)
function getNext() {
if (count >= numRequests)
return;

const req = http.get({
Expand All @@ -40,13 +38,14 @@ function getAll(requestsRemaining) {

count++;
onGC(req, { ongc });

setImmediate(getAll, requestsRemaining - 1);
}

function cb(res) {
res.resume();
done += 1;
res.on('end', () => {
done++;
getNext();
});
}

function ongc() {
Expand All @@ -56,16 +55,14 @@ function ongc() {
setImmediate(status);

function status() {
if (done > 0) {
createClients = false;
if (done === numRequests) {
global.gc();
console.log(`done/collected/total: ${done}/${countGC}/${count}`);
if (countGC === count) {
console.log(`done/collected/total: ${done}/${countGC}/${numRequests}`);
if (countGC === numRequests) {
server.close();
} else {
setImmediate(status);
return;
}
} else {
setImmediate(status);
}

setImmediate(status);
}
Loading