Repository navigation
src: fix Web Locks synchronization across workers - #67608
Open
ShogunPanda wants to merge 1 commit into
Open
ShogunPanda wants to merge 1 commit into
ShogunPanda wants to merge 1 commit into
Conversation
Settle stolen locks in their owning environment instead of from the stealing thread, make the grant decision and the insertion into the held locks a single critical section, keep the environment alive while it has pending requests, cancel native requests on abort, and wake eligible waiters after an owner is cleaned up. Add worker regression tests. Assisted-By: OpenAI GPT-5.6 Sol <openai/gpt-5.6-sol> Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67608 +/- ##
==========================================
- Coverage 90.72% 90.72% -0.01%
==========================================
Files 801 801
Lines 280809 280858 +49
Branches 54212 54215 +3
==========================================
+ Hits 254776 254819 +43
- Misses 16209 16217 +8
+ Partials 9824 9822 -2
🚀 New features to boost your workflow:
|
Contributor
|
hey paolo, can we land #67305 first and rebase this on top? i opened it for #67216 and added the suggested rollback. also, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web Locks keeps process-wide state shared by every
Environment, but the stealing, granting and cleanup code settles per-environment V8 objects and updates that state without respecting isolate ownership or the documented guarantees.This change:
{ steal: true }in their owning environment instead of from the stealing thread;New worker tests cover cross-environment stealing, lifecycle, cancellation and exclusive lock atomicity.
This touches the same area as #67305; I'm happy to rebase on top of it or the other way around, whichever lands first.
AI-assisted work. All changes reviewed by a human.