Repository navigation
permission: revoke fs grants regardless of current path type - #67613
Open
ShogunPanda wants to merge 1 commit into
Open
ShogunPanda wants to merge 1 commit into
ShogunPanda wants to merge 1 commit into
Conversation
A grant is stored with a trailing wildcard when the path is a directory at grant time. `drop()` recomputed that form from the current state of the file system, so a path granted before it existed, or whose type changed since, was silently not revoked. Match the grant in both forms instead, and add tests for both file system scopes. Assisted-By: OpenAI GPT-5.6 Sol <openai/gpt-5.6-sol> Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67613 +/- ##
==========================================
- Coverage 90.72% 90.71% -0.02%
==========================================
Files 801 801
Lines 280809 280811 +2
Branches 54212 54215 +3
==========================================
- Hits 254776 254726 -50
- Misses 16209 16257 +48
- Partials 9824 9828 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process.permission.drop()looks up the grant to revoke by recomputing whether the reference is a directory at drop time, and then searching for that exact string. Grants are stored with a trailing wildcard only when the path was a directory at grant time, so a path that was granted before it existed (a typical output or cache directory), or whose type changed since, was silently not revoked:drop()returned normally and access stayed in force.Revocation now matches the stored grant in both its plain and wildcard forms, without depending on the current state of the file system.
Adds tests for
fs.readandfs.writecovering a path created as a directory after the grant and a directory replaced by a file.AI-assisted work. All changes reviewed by a human.