Repository navigation
zlib: throw on init() while a write is in progress - #67616
Open
ShogunPanda wants to merge 1 commit into
Open
ShogunPanda wants to merge 1 commit into
ShogunPanda wants to merge 1 commit into
Conversation
init() on a compression stream handle could reinitialize the context while a write was still running on the thread pool. Throw instead, like reset() already does. Assisted-By: OpenAI GPT-5.6 Sol <openai/gpt-5.6-sol> Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67616 +/- ##
==========================================
- Coverage 90.72% 90.72% -0.01%
==========================================
Files 801 801
Lines 280809 280817 +8
Branches 54212 54215 +3
==========================================
Hits 254776 254776
- Misses 16209 16247 +38
+ Partials 9824 9794 -30
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reset()andclose()already guard against a write in progress, but theinit()binding for the zlib, Brotli and Zstd streams did not. Calling it while a write was running on the thread pool reinitialized the context under it.This makes
init()throw in that case, matchingreset(), and adds a test.AI-assisted work. All changes reviewed by a human.