Repository navigation
Conversation
This is the next step in the deprecation process for this, for v27. For now we'll keep this available on an opt-in basis, but the following step will be to remove it completely. One case here does not warn: enabling renegotiation client side explicitly, and using it just to accept server-initiated renegotiations. This will be retained for legacy server support scenarios. Initiating renegotiation from the client side still emits a warning. Signed-off-by: Tim Perry <pimterry@gmail.com>
Collaborator
|
Review requested:
|
panva
approved these changes
Nov 19, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67618 +/- ##
==========================================
- Coverage 90.72% 90.71% -0.02%
==========================================
Files 801 801
Lines 280809 280807 -2
Branches 54212 54204 -8
==========================================
- Hits 254776 254730 -46
- Misses 16209 16253 +44
Partials 9824 9824
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next step in the deprecation process for renegotation, as outlined in #67532: disable renegotiation by default in v27.
For now this will be available on an opt-in basis only, with warnings when used. The following step (v28 or later) will be to remove it completely.
One case here does not warn: enabling renegotiation for a client explicitly, and then using it just to accept server-initiated renegotiations. This will be retained for legacy server support scenarios. Initiating renegotiation from the client side still emits a warning.