Skip to content

tls: disable TLS renegotiation by default, with a warning if enabled - #67618

Open
pimterry wants to merge 1 commit into
nodejs:mainfrom
pimterry:tls-drop-client-reneg-major
Open

pimterry wants to merge 1 commit into
nodejs:mainfrom
pimterry:tls-drop-client-reneg-major

Conversation

@pimterry

Copy link
Copy Markdown
Member

The next step in the deprecation process for renegotation, as outlined in #67532: disable renegotiation by default in v27.

For now this will be available on an opt-in basis only, with warnings when used. The following step (v28 or later) will be to remove it completely.

One case here does not warn: enabling renegotiation for a client explicitly, and then using it just to accept server-initiated renegotiations. This will be retained for legacy server support scenarios. Initiating renegotiation from the client side still emits a warning.

This is the next step in the deprecation process for this, for v27. For
now we'll keep this available on an opt-in basis, but the following step
will be to remove it completely.

One case here does not warn: enabling renegotiation client side
explicitly, and using it just to accept server-initiated renegotiations.
This will be retained for legacy server support scenarios. Initiating
renegotiation from the client side still emits a warning.

Signed-off-by: Tim Perry <pimterry@gmail.com>
@pimterry pimterry added the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 19, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/net
  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Nov 19, 2026
@codecov

codecov Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (d9e18d5) to head (d8a6f1f).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/tls/wrap.js 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67618      +/-   ##
==========================================
- Coverage   90.72%   90.71%   -0.02%     
==========================================
  Files         801      801              
  Lines      280809   280807       -2     
  Branches    54212    54204       -8     
==========================================
- Hits       254776   254730      -46     
- Misses      16209    16253      +44     
  Partials     9824     9824              
Files with missing lines Coverage Δ
lib/internal/tls/common.js 97.63% <100.00%> (+0.05%) ⬆️
lib/tls.js 94.11% <100.00%> (+0.25%) ⬆️
lib/internal/tls/wrap.js 95.78% <91.66%> (-0.02%) ⬇️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 19, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 19, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants