Repository navigation
http2: copy small DATA chunks out of socket reads - #67640
Open
ShogunPanda wants to merge 1 commit into
Open
ShogunPanda wants to merge 1 commit into
ShogunPanda wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67640 +/- ##
==========================================
+ Coverage 90.71% 90.73% +0.01%
==========================================
Files 801 801
Lines 280906 280914 +8
Branches 54246 54249 +3
==========================================
+ Hits 254834 254890 +56
+ Misses 16251 16195 -56
- Partials 9821 9829 +8
🚀 New features to boost your workflow:
|
Member
|
Can you run a benchmark? |
A DATA chunk handed to JavaScript was always a slice of the ArrayBuffer holding the whole socket read. A small chunk queued in a paused stream therefore kept alive every other byte of that read, such as other frames or padding. Copy a chunk into a right-sized backing store when the socket read is more than four times larger than the chunk, and keep slicing it otherwise, so full-size DATA frames in a full read still avoid the copy. Assisted-By: OpenAI GPT-5.6 Sol <openai/gpt-5.6-sol> Signed-off-by: Paolo Insogna <paolo@cowtech.it>
ShogunPanda
force-pushed
the
http2-copy-small-data-chunks
branch
from
November 20, 2026 11:20
3c2177e to
8a32586
Compare
Member
|
See also #67327. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A DATA chunk handed to JavaScript was always a slice of the
ArrayBufferholding the whole socket read. A small chunk queued in a paused stream therefore kept every other byte of that read alive (other frames, padding, ...).This copies a chunk into a right-sized backing store when the socket read is more than four times larger than the chunk, and keeps slicing it otherwise. With the default limits, full-size DATA frames in a full socket read are still sliced, so bulk transfers keep avoiding the copy.
The new test sends one-byte DATA frames, each sharing a socket read with a large ignored extension frame, leaves the request body unconsumed and checks that every queued chunk is backed by a small
ArrayBuffer.