Repository navigation
Annotations
1 error
|
Validate first commit message
# a4033fd5a9470de80317fd87da72f752ec6a6b13
ok 1 assisted-by-is-trailer: no Assisted-by metadata
ok 2 co-authored-by-is-trailer: no Co-authored-by metadata
ok 3 fixes-url: skipping fixes-url # SKIP
ok 4 line-after-title: blank line after title
not ok 5 line-length: Line should be <= 72 columns.
---
{
found: 73,
compare: '<=',
wanted: 72,
at: {
line: 6,
column: 72,
body: [
'',
'Replace direct _readableState/_writableState access outside',
'lib/internal/streams/ with the public accessors so internal modules no',
"longer depend on the state objects' shape.",
'',
'Added accessors:',
'- readableErrored / writableErrored (per-side; on a Duplex stream.errored',
' only reflects the readable side, and writable-side getters must be wired',
' into Duplex because the non-enumerable property copy loop skips them)',
'- settable readableHighWaterMark / writableHighWaterMark (validated via a',
' shared validateHighWaterMark helper, ERR_INVALID_ARG_VALUE)',
'- writableDefaultEncoding, readableErrorEmitted / writableErrorEmitted',
'- readableResumeScheduled (isPaused() is not equivalent: resume() with a',
" 'readable' listener leaves isPaused() true while resumeScheduled is set)",
'- autoDestroy get/set on Readable and Writable; a Duplex accessor keeps',
' _readableState/_writableState.autoDestroy in sync when set dynamically',
'',
'Call sites migrated to the accessors:',
'- lib/internal/http2/core.js, lib/internal/http/outgoing.js,',
' lib/internal/http/incoming.js, lib/internal/http/agent.js,',
' lib/internal/http/server.js, lib/internal/http2/compat.js,',
' lib/zlib.js, lib/internal/console/constructor.js,',
' lib/internal/fs/streams.js',
'- lib/internal/webstreams/adapters.js drops duck-typing checks for',
' instanceof Readable / Duplex',
'- lib/internal/http2/core.js onStreamClose() now reads',
' Http2Stream[kState].receivedEnd (set on any null push of the readable',
' side) instead of _readableState.ended, so a server-initiated push stream',
' that ends cleanly is no longer misclassified as an abort.',
'',
'Also fix a regression from the settable high-water-mark setter: its',
'validation made new IncomingMessage(<truthy non-socket>) throw',
'ERR_INVALID_ARG_VALUE, so http/incoming.js now only syncs the socket HWM',
'when it is defined.',
'',
'Non-streams-core _readableState/_writableState references: 43 -> 18.'
]
}
}
...
not ok 6 line-length: Line should be <= 72 columns.
---
{
found: 74,
compare: '<=',
wanted: 72,
at: {
line: 7,
column: 72,
body: [
'',
'Replace direct _readableState/_writableState access outside',
'lib/internal/streams/ with the public accessors so internal modules no',
"longer depend on the state objects' shape.",
'',
'Added accessors:',
'- readableErrored / writableErrored (per-side; on a Duplex stream.errored',
' only reflects the readable side, and writable-side getters must be wired',
' into Duplex because the non-enumerable property copy loop skips them)',
'- settable readableHighWaterMark / writableHighWaterMark (validated via a',
' shared validateHighWaterMark helper, ERR_INVALID_ARG_VALUE)',
'- writableDefaultEncoding, readableErrorEmitted / writableErrorEmitted',
'- readableResumeScheduled (isPaused() is not equivalent: resume() with a',
" 'readable' listener leaves isPaused() true while resumeScheduled is set)",
'- autoDestroy get/set on Readable and Writable; a Duplex accessor keeps',
' _readableState/_writableState.autoDestroy in sync when set dynami
|
background
wait
wait-all
cancel
parallel
Loading