Skip to content

[v22.x] tools: update macOS runner - #67678

Open
inoway46 wants to merge 1 commit into
nodejs:v22.x-stagingfrom
inoway46:v22-macos-15
Open

inoway46 wants to merge 1 commit into
nodejs:v22.x-stagingfrom
inoway46:v22-macos-15

Conversation

@inoway46

Copy link
Copy Markdown
Contributor

Switch the macOS runner to macos-15 because macos-14 has been retired.

Fixes: #67643

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Nov 21, 2026
@inoway46
inoway46 marked this pull request as ready for review November 21, 2026 13:46
Switch to macos-15 because macos-14 has been retired.

Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Assisted-by: Codex
@MikeMcC399

Copy link
Copy Markdown
Member

Is parallel/test-debugger-exceptions a flaky test in the updated workflow .github/workflows/test-macos.yml ?

@inoway46

inoway46 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor Author

This looks like the known flaky test fixed by 2004fbd1642f, which is included in v26 and v24 but not v22. It may be worth backporting the fix to v22 as well.

Failing run: https://github.com/nodejs/node/actions/runs/44910531890

@MikeMcC399

Copy link
Copy Markdown
Member

This looks like the known flaky test fixed by 2004fbd1642f, which is included in v26 and v24 but not v22. It may be worth backporting the fix to v22 as well.

It depends how often the flake is appearing whether this is worthwhile. At least if this PR lands, the workflow can run again. Since there will not be so many PRs to the v22.x branch in the future, until its EOL in Apr 2027, it may be acceptable to have to re-run the workflow manually sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants