Skip to content

tools: update sccache, cache Rust builds - #67694

Open
Renegade334 wants to merge 3 commits into
nodejs:mainfrom
Renegade334:gha-sccache-rust
Open

Renegade334 wants to merge 3 commits into
nodejs:mainfrom
Renegade334:gha-sccache-rust

Conversation

@Renegade334

Copy link
Copy Markdown
Member

The Rust builds are unchanged in between V8 major updates, so caching them is highly efficient. sccache 0.19.0 brings in some additional efficiency changes for Rust, for good measure.

Additionally, don't try to write to the GHA cache in the manually-dispatched stress-test workflow, which is the same behaviour as we already have in the manually-dispatched benchmark workflow.

Signed-off-by: René <rene@renegade334.me.uk>
Signed-off-by: René <rene@renegade334.me.uk>
Signed-off-by: René <rene@renegade334.me.uk>
@Renegade334 Renegade334 added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Nov 22, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 22, 2026
@Renegade334 Renegade334 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. dont-land-on-v27.x PRs that should not land on the v27.x-staging branch and should not be released in v27.x. labels Nov 22, 2026
@Renegade334

Copy link
Copy Markdown
Member Author

It also occurs to me that there's absolutely zero point in landing these PRs on staging branches, since the branch condition for activating sccache in these workflows is never met...

@aduh95

aduh95 commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

It also occurs to me that there's absolutely zero point in landing these PRs on staging branches, since the branch condition for activating sccache in these workflows is never met...

Avoiding conflicts maybe? If there's no reason NOT to backport, let's remove the labels

@aduh95 aduh95 removed dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. dont-land-on-v27.x PRs that should not land on the v27.x-staging branch and should not be released in v27.x. labels Nov 22, 2026
@Renegade334

Copy link
Copy Markdown
Member Author

These won't land on <=v24.x due to the perfetto workflow, the others are dealer's choice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants