Repository navigation
cli: remove --no-experimental-sqlite flag - #67698
Open
christianaurichzm wants to merge 1 commit into
Open
christianaurichzm wants to merge 1 commit into
christianaurichzm wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
node:sqlite is stable, so it no longer needs an opt-out. --experimental-sqlite stays as an undocumented no-op, like --experimental-websocket. Builds without SQLite keep hiding the module through a new hasSQLite config flag. Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
christianaurichzm
force-pushed
the
sqlite-noop-flag
branch
from
November 22, 2026 14:54
82dfdb2 to
1f3f0a4
Compare
christianaurichzm
requested review from
aduh95,
cjihrig,
mcollina and
trivikr
November 22, 2026 14:54
aduh95
reviewed
Nov 22, 2026
Comment on lines
+90
to
+95
| #if HAVE_SQLITE | ||
| READONLY_TRUE_PROPERTY(target, "hasSQLite"); | ||
| #else | ||
| READONLY_FALSE_PROPERTY(target, "hasSQLite"); | ||
| #endif | ||
|
|
Contributor
There was a problem hiding this comment.
Is it really needed when there's process.config.variables.node_use_sqlite already?
aduh95
reviewed
Nov 22, 2026
Comment on lines
+207
to
+208
| // The option is a no-op, so builds without SQLite never expose node:sqlite. | ||
| ['sqlite', true, hasSQLite ? null : '--experimental-sqlite'], |
Contributor
There was a problem hiding this comment.
That's confusing, IIUC that implies that when node was built without SQLite support, --experimental-sqlite is no longer no-op?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #67654, as discussed with @aduh95 there.
node:sqliteis stable now, so it doesn't need an opt-out. This makes--experimental-sqlitean undocumented no-op, like--experimental-websocketafter #65284. That's semver-major because--no-experimental-sqlitenow fails as an invalid negation, andnode.config.jsonrejects an"experimental-sqlite"key with either value.Builds configured
--without-sqlitestill hide the module. The gate now readshasSQLitefrom the config binding (already in the typings since #60906) instead of the CLI option.