Skip to content

cli: remove --no-experimental-sqlite flag - #67698

Open
christianaurichzm wants to merge 1 commit into
nodejs:mainfrom
christianaurichzm:sqlite-noop-flag
Open

christianaurichzm wants to merge 1 commit into
nodejs:mainfrom
christianaurichzm:sqlite-noop-flag

Conversation

@christianaurichzm

Copy link
Copy Markdown
Member

Follow-up to #67654, as discussed with @aduh95 there.

node:sqlite is stable now, so it doesn't need an opt-out. This makes --experimental-sqlite an undocumented no-op, like --experimental-websocket after #65284. That's semver-major because --no-experimental-sqlite now fails as an invalid negation, and node.config.json rejects an "experimental-sqlite" key with either value.

Builds configured --without-sqlite still hide the module. The gate now reads hasSQLite from the config binding (already in the typings since #60906) instead of the CLI option.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/loaders
  • @nodejs/sqlite
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues and PRs related to Node.js configuration and feature settings. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Nov 22, 2026
node:sqlite is stable, so it no longer needs an opt-out.
--experimental-sqlite stays as an undocumented no-op, like
--experimental-websocket. Builds without SQLite keep hiding the
module through a new hasSQLite config flag.

Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
@christianaurichzm christianaurichzm added semver-major PRs that contain breaking changes and should be released in the next major version. sqlite Issues and PRs related to the SQLite subsystem. labels Nov 22, 2026
Comment thread src/node_config.cc
Comment on lines +90 to +95
#if HAVE_SQLITE
READONLY_TRUE_PROPERTY(target, "hasSQLite");
#else
READONLY_FALSE_PROPERTY(target, "hasSQLite");
#endif

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really needed when there's process.config.variables.node_use_sqlite already?

Comment on lines +207 to +208
// The option is a no-op, so builds without SQLite never expose node:sqlite.
['sqlite', true, hasSQLite ? null : '--experimental-sqlite'],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's confusing, IIUC that implies that when node was built without SQLite support, --experimental-sqlite is no longer no-op?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. config Issues and PRs related to Node.js configuration and feature settings. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants