Repository navigation
test(pool): cover a protocol probe whose request is rejected before dispatch - #6142
Open
MIbtehajNasar wants to merge 1 commit into
Open
MIbtehajNasar wants to merge 1 commit into
MIbtehajNasar wants to merge 1 commit into
Conversation
3 of 7 tasks
…ispatch With allowH2 on an https: origin, a Pool makes one Client its protocol probe and queues later requests until ALPN completes. If the request that made a client the probe is rejected while the Request is built (for example an invalid header), the client never connects. This used to leave the probe set and every later request queued forever (nodejs#6141); it is fixed on main since dispatch no longer reports busy after a synchronous failure (nodejs#6180). Add regression tests for it, including after a clientTtl rotation. Fixes: nodejs#6141
MIbtehajNasar
force-pushed
the
fix-6141-probe-stuck-on-rejected-request
branch
from
November 22, 2026 09:58
ac13ee8 to
f9b7e37
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6142 +/- ##
=======================================
Coverage 91.74% 91.74%
=======================================
Files 113 113
Lines 44849 44849
=======================================
+ Hits 41147 41148 +1
+ Misses 3702 3701 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6141
With
allowH2on anhttps:origin, a Pool makes one Client its protocol probe and queues later requests until ALPN completes. If the request that made a client the probe was rejected while the Request was built (for example an invalidexpectheader), the client never connected, the probe stayed set, and every later request on the Pool queued forever.This PR originally fixed that in
Pool[kOnClientBusy]. Since #6180,dispatch()no longer reports busy after a synchronous failure, which also fixes #6141, so I've reduced this PR to the regression tests:clientTtlrotationBoth pass on
mainand fail if the #6180 change is reverted.