Repository navigation
feat(DEP0199): migrate internal HTTP imports to node:http - #576
Open
vishalrajofficial wants to merge 4 commits into
Open
vishalrajofficial wants to merge 4 commits into
vishalrajofficial wants to merge 4 commits into
Conversation
Signed-off-by: Vishal Raj <9031842908.vk@gmail.com>
AugustinMauroy
requested changes
Nov 18, 2026
Member
|
and rest it's seem good |
Signed-off-by: Vishal Raj <9031842908.vk@gmail.com>
Use ast-grep string_fragment query instead of regex for unquoting string nodes. Simplify import and require handling by leveraging @nodejs/codemod-utils directly, replace kind() === checks with .is(), handle newlines dynamically, and update test fixtures. Signed-off-by: Vishal Raj <9031842908.vk@gmail.com>
Author
|
Thanks for the feedback! Updated:
All 12 recipe tests, type checks, and linting pass cleanly. |
…query and remove helper function Signed-off-by: Vishal Raj <9031842908.vk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a codemod for DEP0199 to migrate legacy imports of internal Node.js HTTP modules (
_http_*) to the publicnode:httpmodule.Features
_http_agent,_http_client,_http_incoming,_http_outgoing, and_http_servertonode:http.node:prefixed specifiers (e.g._http_agentandnode:_http_agent).node:http._http_common), escaped namespace objects, and unknown properties, emitting warnings for manual review.Fixes #556