Repository navigation
perf(experimental): activate reckless-by-default IBD and harden the switch-off - #1
Merged
nullPointerEnjoyer merged 24 commits intoNov 13, 2026
Conversation
Owner
Author
CI statusCI had never run on this branch series (the base experimental branch had zero workflow runs), so enabling it peeled through several layers of accumulated issues. All fixed on this branch; current state on
What CI surfaced and this PR fixes (all pre-existing on the series — the code had never been compiled with
Verified locally before pushing: full-workspace clippy (both passes) clean; the containerized suites green ( |
nullPointerEnjoyer
merged commit Nov 13, 2026
60bd6e1
into
experimental/ibd-and-indexer-performance
33 of 35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--enable-db-reckless-mode-in-ibdand the other boolean CLI options usedArgAction::SetTrueonOption<bool>. clap materializesSome(false)for an absent flag, so:options.X.or(config_X)always sawSome(false))Master is unaffected: it has no daemon default-on, so the old flag semantics are coherent there as an opt-in.
Changes
ArgAction::Setwithvalue_name = "true|false"on everyOption<bool>option (absence yieldsNone, so config file / env can take precedence)=trueML_*env vars no longer parse; they require an explicittrue/false)None, explicit values, bare flag rejected), env-var layer (valid/invalid values), and an end-to-end clap→config-merge test whose config value differs from the buggy materialized default (fails without the fix)Measured impact (full mainnet sync to 725,000, same host and protocol as the earlier A/B runs)
Cumulative stage wall at 725k blocks: 24.70 → 6.65 ms/block (commit 18.62 → 0.48 ms/block; connect unchanged at ~6 ms/block). The switch-off was exercised in vivo on catch-up to a fresh tip: reckless mode disabled, forced sync ok.
Testing
cargo test -p node-lib(21 unit + 3 integration),-p chainstate(51),-p chainstate-test-suite(454) — all green.