Repository navigation
feat(terrain): add a shore prop for a walkable island beach - #78
Merged
Merged
Conversation
- `Terrain` takes `shore`, the width in units of a beach around an island (needs `falloff`) - The beach falls 2 units at one slope, from 0.4 above the world ground to wading depth, so `shore: 6` is about 18° - Land near the coast is lowered to meet the beach, and the island grows outward by `shore` - Worlds that don't set `shore` keep every height they had - The workshop's "Island cove" template has a beach, with its dock and sailboat moved in to meet it [CONTRIBUTORS] - New beach branch in `terrainHeight()` in `surfaces/terrain.ts`, the old path is untouched - Tests pin shore-less heights to values recorded from `main` and hold the beach under 25° - `shore` slider range in the workshop's `schema/ranges.ts` - Regenerated `registry/` and the component docs, which also brings `person.md` up to date Refs #76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terraingainsshore, a beach an avatar can walk up out of the sea. A small island's bare coast is close to a cliff: on the workshop's "Island cove" it runs 30° to 66°, which testing the swimming in #76 showed an avatar can't climb.shoreis the width, in units, of a band past the land's edge where the ground falls 2 units at one slope, from 0.4 above the world ground to wading depth, then drops to the deep as beforeshore: 6is about 18°, and about 4.3 is the 25° markflatRadiusflattens the land alone (scaling the sea bed would steepen it), and a pad wider than the land pushes the beach out to its edgeshore, so it needs room insidesizeWorlds without
shorekeep every height they hadterrainHeight()is untouched, andshoreis read only on an island (one withfalloff)toBeagainst heights recorded frommainbefore the change"Island cove" template
shore: 6: the steepest stretch between +0.3 m and -1.5 m on the collider mesh goes from 60.8° to 19.6°Dockmoves from[0, 0, 19]to[0, 0, 9.4]and theSailboatfrom z 24 to z 15.5. The dock used to start 9 m out from the waterline over 7 m of water, and now starts on the sandAlso
shoreslider range in the workshop, regeneratedregistry/and component docsperson.mdpicks up two prop descriptions from fix(person): keep clothing layers apart and draw a hoodie as one #77 that were not regenerated thereKnown limit: on a coarse grid (cells much wider than about 1.5 m) the crease at the bottom of the beach can show one steep triangle, 31° at
resolution: 32on an 80 x 60 terrain.Testing:
just checkpasses. In the workshop, aPlayerholding W walks from 1.6 m deep onto land in 2.5 s withshore: 6; on the old coast it slides to the bottom.Refs #76