Repository navigation
fix: make Pool steps walkable, walls solid, Player steady on slopes - #79
Merged
Merged
Conversation
- `Pool`'s exit steps can be walked: the stock `Player` climbs from the basin floor onto the deck and back down - `Pool`'s basin walls are solid, an avatar on the basin floor no longer leaves through them - `Player` keeps walking speed on a slope whichever way it moves: backing down, backing up or across [CONTRIBUTORS] - `Pool` flight is 0.25 m risers counted down from the coping, under one `ConvexHullCollider` wedge - One `CuboidCollider` per basin wall, sized from the same list as the wall meshes - `SlopeRay` in `Player.tsx` turns ecctrl's slope ray to the direction of travel, which ecctrl only does under `autoBalance` - Regenerated the `registry/` manifests and the `Pool` docs page, plus the `Person` docs page that was stale on `main`
…meida-d13391 - `Pool.tsx`: keep both import sets, the wedge collider's and the water's - `registry/components/player.json`, `registry/components/pool.json`: regenerated with `just registry`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool's exit steps can be walked, the stockPlayerclimbs from the basin floor onto the deck and back downdepthneeds, under oneConvexHullColliderwedgestepsprop is unchangedPool's basin walls are solidCuboidColliderper wall, the size of its meshPlayerkeeps its pace on a slope whichever way it walksautoBalance, whichPlayerturns off, so the ray stayed in front of the cameraSlopeRayinpackages/components/src/Player.tsxturns it to follow the avatar's velocity; ecctrl is not patchedAlso in the diff
apps/docs/src/content/docs/components/person.mdis regenerated: twoPersonprop descriptions changed in fix(person): keep clothing layers apart and draw a hoodie as one #77 without the page being rebuiltTesting:
just checkpasses. Walked in the workshop with the stockPlayer: pool floor to deck and back, all four walls of the default pool and adepth: 2.4pool, and W/S/A/D on a 32° ramp, aStaircaseand flat ground, in first and third person. Gamepad and touch joystick were not driven.Refs #76 (also edits
Player.tsxandPool.tsx)