Repository navigation
Use 0-based split column names in the translated books - #2267
Merged
Merged
Conversation
split column names its columns from column0 now and the English pages already show that. This updates the same examples in the de, es, ko, pt-BR and zh-CN books.
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split columnnames its columns starting fromcolumn0now and the English book already shows that, but some of the translated pages still had the old output.This updates the default column names in the example tables and the
get column1line (nowget column0) in the loading data pages for de, es, ko, pt-BR and zh-CN, plus thesplit columnexample in the Korean strings page. es and pt-BR also had the really oldColumn1spelling.I left the Japanese page out since #2264 is still open for it. Checked with nu 0.116.1 that
split column "|" | str trim | get column0gives the first names like the docs say.