Skip to content

Upgrade to clarity 5.0.1 (re-land #95 with the entity filter fix) - #97

Merged
howardchung merged 2 commits into
odota:masterfrom
spheenik:clarity-5.0.1
Oct 5, 2026
Merged

howardchung merged 2 commits into
odota:masterfrom
spheenik:clarity-5.0.1

Conversation

@spheenik

@spheenik spheenik commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

This re-applies #95, which was reverted in #96, and moves from clarity 5.0.0 to 5.0.1. 5.0.1 fixes the bug behind the no field for class ... at ... failures reported in #95.

Cause

The bug was in clarity's new entity filter, which #95 turns on. Sometimes a replay creates an entity of a class the filter skips at an index that still holds an entity the filter keeps (for example CDOTA_Item_Rune). Clarity skipped the new entity but didn't remove the old one. The next update at that index was then decoded with the old entity's class, and the parse failed. Which class appears in the error depends on which entity was left over, which is why the reported class names varied. Only some replays reuse an index this way, which is why only a share of parses failed.

Fix

Clarity 5.0.1 now deletes the old entity in that case. The fix is skadistats/clarity@bcb08e5. This PR adds nothing beyond #95 except the version bump.

Verification

If anything still goes wrong, -Dopendota.entityFilter=false turns the filter off without a redeploy of new code.

🤖 Generated with Claude Code

spheenik and others added 2 commits October 5, 2026 09:44
5.0.1 fixes the entity-filter bug that caused the 'no field for class ... at ...' parse failures after odota#95.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@howardchung
howardchung merged commit 0ab08be into odota:master Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants