Repository navigation
Upgrade to clarity 5.0.1 (re-land #95 with the entity filter fix) - #97
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-applies #95, which was reverted in #96, and moves from clarity 5.0.0 to 5.0.1. 5.0.1 fixes the bug behind the
no field for class ... at ...failures reported in #95.Cause
The bug was in clarity's new entity filter, which #95 turns on. Sometimes a replay creates an entity of a class the filter skips at an index that still holds an entity the filter keeps (for example
CDOTA_Item_Rune). Clarity skipped the new entity but didn't remove the old one. The next update at that index was then decoded with the old entity's class, and the parse failed. Which class appears in the error depends on which entity was left over, which is why the reported class names varied. Only some replays reuse an index this way, which is why only a share of parses failed.Fix
Clarity 5.0.1 now deletes the old entity in that case. The fix is skadistats/clarity@bcb08e5. This PR adds nothing beyond #95 except the version bump.
Verification
If anything still goes wrong,
-Dopendota.entityFilter=falseturns the filter off without a redeploy of new code.🤖 Generated with Claude Code