Repository navigation
refactor(view): remove the analytic binder (RS-W2-3 PR-B) - #553
Merged
Merged
Conversation
PR-A made analytic_binders redundant: a routine's non-JSON arguments are its declared inputs, provided by the environment's role supply. - Delete _apply_analytic_binders, its call in _run_analytic_function, ActionParameter.analytic_binders and the resolver's binder checks. - ActionParameter accepts the key for one release and ignores it: silently when empty (older generated specs), with a DeprecationWarning and a logged warning naming the parameters when not. - No built-in, demo or trellis-analytics 0.4.0 spec set it, so no spec is rewritten. - Read-back R4: drop the dead getattr on func_decl. - Tests: deprecation shim, a binder-carrying spec running on declared inputs alone, and a reader input supplied by the environment (replaces the ISSUE-138 binder tests). Docs and ISSUE-138 updated. Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RS-W2-3 PR-B: remove the analytic binder
PR-A (#552) made
analytic_bindersredundant. A routine's non-JSON arguments (clients, readers, the viewer) are now its declared inputs, and the environment's role supply provides them:PlainSupplyin plain pyegeria,PortalSupplyin the Portal, and RE's own supply. This PR deletes the binder mechanism.Changes
_apply_analytic_binders, its call in_run_analytic_function,ActionParameter.analytic_binders, and the resolver's binder checks.ActionParameterstill accepts theanalytic_binderskey and ignores it:md_processing/data/generated_format_sets.jsonload this way.DeprecationWarningthat names the parameters it bound.getattronfunc_decl.docs/output-formats-and-report-specs.mdand ISSUE-138 inPYEGERIA_ISSUES.mdare updated.Release-note text (for 6.2.26)
analytic_bindersis deprecated. It is ignored from 6.2.26 and will be removed in a later release. A routine that needs a non-JSON argument declares it as an input, and the role supply provides it.mgr/ce/expert/clientbut declares noinputs. The fix is to declare its inputs.Verification
READBACK-RS-W2-3-PR-B-and-portal-2026-11-08.md):analytic_bindersappears only in the shim.🤖 Generated with Claude Code