fix: stop task dispatch after an interrupted tick - #62
Merged
Merged
Conversation
Owner
|
Thanks for this. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Calling
pause()orstop()in a tick listener still runs that tick's tasks. Later tasks also run after an earlier task callback stops the timer.Check the existing generation counter before dispatching each task. This also ends the old tick when a listener pauses and resumes immediately. Pending tasks then run on the next scheduled tick.
Eight cases cover listeners, task callbacks, reset and restart behavior. Five fail on master.
npm testpasses all 79 tests on Node 22 and 24, including lint and type checks.npm run buildandnpm run coverpass, with 100% coverage.