Repository navigation
feat(agents): review changes to the starter agent catalog - #685
Merged
Merged
Conversation
No repo-local reviewer matches starter-agents/**, so catalog prompt files go unassigned and withhold approval. catalog:starter-agents matches only that directory, is required when it matches, and checks generality, shared prompt structure, lane scoping, sandbox-safe instructions, routing, and README accuracy. Twapp-Session: 2cffedba-c2e2-4183-88d9-3e29627dc08a
monit-reviewer
previously approved these changes
Oct 21, 2026
monit-reviewer
left a comment
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: b56cc0eb0918
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| harness-engineering:repo-health | 0 |
| structure:repo-health | 1 |
| policies:conventions | 0 |
| structure:harness-engineering | 0 |
structure:repo-health (1 finding)
Minor - .codereview/agents/catalog/starter-agents/prompt.md:33
Invariant: a 'What not to report' exclusion should point at a check that actually exists, because it tells the reviewer to stop looking. This line suppresses agent schema errors on the grounds that
internal/agents/starter_catalog_test.goloads the catalog with the strict parser. That file does not exist at the PR head or on the base branch. Until #684 adds a test with exactly that name, the reviewer is told to ignore a class of errors that nothing enforces. If #684 names or places the test differently, the reference goes stale without any check noticing. Fix: either reference the enforcement by behavior (for example 'the catalog's strict-parser load test') without a hard-coded path, or confirm #684 adds that exact path and note the ordering dependency in the PR.
Reviewer Coverage
Complete coverage details are retained in the local coverage.json artifact.
harness-engineering:repo-health— complete (constrained); scope: 2 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml; body-inspected: 2 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml; skipped: none; constraints: Scope limited to the two index.yaml files; the sibling prompt.md in the checkout is outside assignment scope and was not reviewed. The starter-agents/ directory does not exist on the base branch, so the file_globs match could not be checked against real files; cr agents show was not run.structure:repo-health— complete (broad); scope: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; body-inspected: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; skipped: none; context (not coverage): 1 file; examples:docs/review-guidance.md; constraints: Did not runcr agents show; the strict-parser load claim in the PR body was not independently verified. starter-agents/ and starter-agents/README.md do not exist at the PR head; they are proposed in #684, so the prompt's Read first and README checks could not be validated against real files.policies:conventions— complete (broad); scope: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; body-inspected: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; skipped: none; constraints: Shared Review bar drift against other catalog prompts could not be checked because the catalog is not present. starter-agents/, starter-agents/README.md and internal/agents/starter_catalog_test.go do not exist on this head (they come from #684), so references to them in the new prompt could not be verified.structure:harness-engineering— complete (broad); scope: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; body-inspected: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; skipped: none; constraints: Did not runcr agents show; checked the file shapes against sibling repo-local agents and the required_on_match documentation in README.md. The prompt references starter-agents/README.md and internal/agents/starter_catalog_test.go, which do not exist on this branch; the PR states they arrive with #684, so this was not treated as a defect.
0 PR discussion threads considered. 0 summarized; 0 resolved.
Note: This PR modifies reviewer definitions under
.codereview/agents/. The review was conducted using base-branch versions; changes will affect future reviews after merge.
Completed in 1m 37s | ~$1.80 (est.) | claude-sonnet-5-5 | cr 0.10.344
| Field | Value |
|---|---|
| Model | claude-sonnet-5-5 |
| Reviewers | harness-engineering:repo-health, structure:repo-health, policies:conventions, structure:harness-engineering |
| Engine | claude_cli · claude-sonnet-5-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 1m 37s wall · 3m 00s compute |
| Cost | ~$1.80 (est.) |
| Pricing basis | baseline-2026-10-02/pricing |
| Tokens | 54 in / 9.3k out |
Per-workstream usage
orchestrator-selection— claude-sonnet-5-5- In: 6
- Out: 1.6k
- Cache read: 59.7k
- Cache create: 52.2k
- Cost: ~$0.24 (est.)
- Duration: 21s
harness-engineering:repo-health— claude-sonnet-5-5- In: 10
- Out: 1.5k
- Cache read: 159.7k
- Cache create: 52.8k
- Cost: ~$0.26 (est.)
- Duration: 28s
structure:repo-health— claude-sonnet-5-5- In: 10
- Out: 2.1k
- Cache read: 161.8k
- Cache create: 54.6k
- Cost: ~$0.27 (est.)
- Duration: 33s
policies:conventions— claude-sonnet-5-5- In: 12
- Out: 1.9k
- Cache read: 210.3k
- Cache create: 53.8k
- Cost: ~$0.28 (est.)
- Duration: 37s
structure:harness-engineering— claude-sonnet-5-5- In: 10
- Out: 1.7k
- Cache read: 162.3k
- Cache create: 54.6k
- Cost: ~$0.27 (est.)
- Duration: 43s
orchestrator-rollup— claude-sonnet-5-5- In: 6
- Out: 476
- Cache read: 93.6k
- Cache create: 117.5k
- Cost: ~$0.49 (est.)
- Duration: 16s
Twapp-Session: 2cffedba-c2e2-4183-88d9-3e29627dc08a
monit-reviewer
approved these changes
Oct 21, 2026
monit-reviewer
left a comment
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 3bfc9b996fd8
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| harness-engineering:repo-health | 0 |
| structure:repo-health | 0 |
| policies:conventions | 0 |
| structure:harness-engineering | 0 |
Reviewer Coverage
Complete coverage details are retained in the local coverage.json artifact.
harness-engineering:repo-health— complete (constrained); scope: 2 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml; body-inspected: 2 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml; skipped: none; constraints: Scope limited to the two index.yaml files; the sibling prompt.md is outside assignment scope and was not reviewed. starter-agents/ does not exist on the base branch, so the file_globs match could not be checked against real files; cr agents show was not run.structure:repo-health— complete (constrained); scope: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; body-inspected: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; skipped: none; constraints: Did not runcr agents show; the strict-parser load claim in the PR body was not independently verified. starter-agents/ and its README do not exist at the PR head; they are proposed in #684, so the prompt's Read first and README checks could not be validated against real files.policies:conventions— complete (constrained); scope: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; body-inspected: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; skipped: none; constraints: starter-agents/ and its README do not exist on this head (they come from #684), so the prompt's references to them and Review bar drift against sibling prompts could not be verified.structure:harness-engineering— complete (constrained); scope: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; body-inspected: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; skipped: none; constraints: Did not runcr agents show; checked file shapes by reading the three changed files. The prompt references starter-agents/README.md, which does not exist on this branch; the PR states it arrives with #684, so this was not treated as a defect.
0 PR discussion threads considered. 0 summarized; 0 resolved.
Note: This PR modifies reviewer definitions under
.codereview/agents/. The review was conducted using base-branch versions; changes will affect future reviews after merge.
Completed in 1m 16s | ~$2.44 (est.) | claude-sonnet-5-5 | cr 0.10.344
| Field | Value |
|---|---|
| Model | claude-sonnet-5-5 |
| Reviewers | harness-engineering:repo-health, structure:repo-health, policies:conventions, structure:harness-engineering |
| Engine | claude_cli · claude-sonnet-5-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 1m 16s wall · 1m 57s compute |
| Cost | ~$2.44 (est.) |
| Pricing basis | baseline-2026-10-02/pricing |
| Tokens | 34 in / 4.4k out |
Per-workstream usage
harness-engineering:repo-health— claude-sonnet-5-5- In: 8
- Out: 1.0k
- Cache read: 229.1k
- Cache create: 82.0k
- Cost: ~$0.38 (est.)
- Duration: 23s
structure:repo-health— claude-sonnet-5-5- In: 8
- Out: 1.1k
- Cache read: 235.7k
- Cache create: 85.4k
- Cost: ~$0.40 (est.)
- Duration: 24s
policies:conventions— claude-sonnet-5-5- In: 6
- Out: 858
- Cache read: 144.7k
- Cache create: 83.1k
- Cost: ~$0.37 (est.)
- Duration: 26s
structure:harness-engineering— claude-sonnet-5-5- In: 8
- Out: 1.1k
- Cache read: 193.7k
- Cache create: 130.6k
- Cost: ~$0.57 (est.)
- Duration: 22s
orchestrator-rollup— claude-sonnet-5-5- In: 4
- Out: 318
- Cache read: 14.4k
- Cache create: 177.5k
- Cost: ~$0.72 (est.)
- Duration: 19s
piekstra
marked this pull request as ready for review
October 21, 2026 22:34
monit-reviewer
approved these changes
Oct 22, 2026
monit-reviewer
left a comment
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: f9b001b4a4c0
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| harness-engineering:repo-health | 0 |
| structure:repo-health | 0 |
| policies:conventions | 0 |
| structure:harness-engineering | 0 |
Reviewer Coverage
Complete coverage details are retained in the local coverage.json artifact.
harness-engineering:repo-health— complete (constrained); scope: 2 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml; body-inspected: 2 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml; skipped: none; constraints: Scope limited to the two index.yaml files; the sibling prompt.md is outside assignment scope and was not reviewed. starter-agents/ does not exist on the base branch, so the file_globs match could not be checked against real files; cr agents show was not run.structure:repo-health— complete (constrained); scope: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; body-inspected: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; skipped: none; constraints: Did not runcr agents show; the strict-parser load claim in the PR body was not independently verified. starter-agents/ and its README do not exist at the PR head; they are proposed in #684, so the prompt's Read first and README checks could not be validated against real files.policies:conventions— complete (constrained); scope: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; body-inspected: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; skipped: none; constraints: starter-agents/ and its README do not exist on this head (they come from #684), so the prompt's references to them and Review bar drift against sibling prompts could not be verified.structure:harness-engineering— complete (constrained); scope: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; body-inspected: 3 files; examples:.codereview/agents/catalog/index.yaml,.codereview/agents/catalog/starter-agents/index.yaml,.codereview/agents/catalog/starter-agents/prompt.md; skipped: none; constraints: Did not runcr agents show; checked file shapes by reading the three changed files. The prompt references starter-agents/README.md, which does not exist on this branch; the PR states it arrives with #684, so this was not treated as a defect.
0 PR discussion threads considered. 0 summarized; 0 resolved.
Note: This PR modifies reviewer definitions under
.codereview/agents/. The review was conducted using base-branch versions; changes will affect future reviews after merge.
Completed in 1m 21s | ~$4.60 (est.) | claude-sonnet-5-5 | cr 0.10.344
| Field | Value |
|---|---|
| Model | claude-sonnet-5-5 |
| Reviewers | harness-engineering:repo-health, structure:repo-health, policies:conventions, structure:harness-engineering |
| Engine | claude_cli · claude-sonnet-5-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 1m 21s wall · 2m 00s compute |
| Cost | ~$4.60 (est.) |
| Pricing basis | baseline-2026-10-02/pricing |
| Tokens | 38 in / 4.6k out |
Per-workstream usage
harness-engineering:repo-health— claude-sonnet-5-5- In: 8
- Out: 999
- Cache read: 251.3k
- Cache create: 204.5k
- Cost: ~$0.88 (est.)
- Duration: 25s
structure:repo-health— claude-sonnet-5-5- In: 8
- Out: 1.1k
- Cache read: 258.7k
- Cache create: 212.4k
- Cost: ~$0.91 (est.)
- Duration: 26s
policies:conventions— claude-sonnet-5-5- In: 8
- Out: 1.0k
- Cache read: 254.3k
- Cache create: 208.4k
- Cost: ~$0.89 (est.)
- Duration: 26s
structure:harness-engineering— claude-sonnet-5-5- In: 8
- Out: 1.1k
- Cache read: 260.4k
- Cache create: 214.0k
- Cost: ~$0.92 (est.)
- Duration: 24s
orchestrator-rollup— claude-sonnet-5-5- In: 6
- Out: 411
- Cache read: 151.1k
- Cache create: 240.2k
- Cost: ~$1.00 (est.)
- Duration: 18s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
catalog:starter-agents, a repo-local reviewer forstarter-agents/, the general catalog proposed in #684.Without it, no reviewer of this repository is assigned the catalog's
prompt.mdfiles: this repo'sdocumentation:docsreplaces any profile docs agent by ID and matches only top-level Markdown anddocs/, and the other repo-local agents do not matchstarter-agents/**. The review of #684 withheld approval for exactly that reason (14 unassigned prompt files). Repo-local agents load from the base branch, so #684 cannot add this coverage for its own review; this lands first.The reviewer matches only
starter-agents/**and setsrequired_on_match, so any PR touching the catalog gets it and no other PR pays for it. It checks what is specific to shipping prompts to other teams: no organization-specific content, the shared prompt structure and review bar, lane scoping without naming other agents, instructions a sandboxed reviewer can follow, routing that matches the prompt, and README accuracy.Type of Change
Checklist
make tidypassesmake lintpassesmake testpassesmake buildpassesAgents-only change;
cr agents show catalog:starter-agents --agents-dir .codereview/agentsloads it under the strict parser.Related Issues
Needed before #684 can be reviewed with full coverage.
Model: Claude Opus 5.5 (1M context, xhigh effort) in Claude Code.