Skip to content

fix: render literal Chocolatey download URLs #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rianjs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: render literal Chocolatey download URLs #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packaging/chocolatey/google-readonly/tools/chocolateyInstall.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,22 @@
$ErrorActionPreference = 'Stop'

$version = $env:ChocolateyPackageVersion
$toolsDir = Split-Path -Parent $MyInvocation.MyCommand.Definition

$urlAmd64 = 'URL_AMD64_PLACEHOLDER'
$urlArm64 = 'URL_ARM64_PLACEHOLDER'
$checksumAmd64 = 'CHECKSUM_AMD64_PLACEHOLDER'
$checksumArm64 = 'CHECKSUM_ARM64_PLACEHOLDER'

if ($env:PROCESSOR_ARCHITECTURE -eq 'ARM64') {
$arch = 'arm64'
$url = $urlArm64
$checksum = $checksumArm64
} elseif ([Environment]::Is64BitOperatingSystem) {
$arch = 'amd64'
$url = $urlAmd64
$checksum = $checksumAmd64
} else {
throw "32-bit Windows is not supported. gro requires 64-bit Windows."
}

$url = "https://github.com/open-cli-collective/google-cli/releases/download/v${version}/gro_v${version}_windows_${arch}.zip"

Install-ChocolateyZipPackage -PackageName $env:ChocolateyPackageName `
-Url $url `
-UnzipLocation $toolsDir `
Expand Down
9 changes: 4 additions & 5 deletions packaging/chocolatey/google-readwrite/tools/chocolateyInstall.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,22 @@
$ErrorActionPreference = 'Stop'

$version = $env:ChocolateyPackageVersion
$toolsDir = Split-Path -Parent $MyInvocation.MyCommand.Definition

$urlAmd64 = 'URL_AMD64_PLACEHOLDER'

@rianjs-bot rianjs-bot Bot Sep 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The active shared release workflow at open-cli-collective/.github/.github/workflows/release.yml@v1 only verifies and replaces the checksum placeholders; it has no replacement or assertion for URL_AMD64_PLACEHOLDER/URL_ARM64_PLACEHOLDER. Consequently the published google-readwrite package will retain this literal non-URL and fail to download on installation. Ship the corresponding URL rendering/assertion in the shared workflow and consume that released revision before this template can be released.

Reply inline to this comment.

@rianjs rianjs Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shared v1 tag was updated to 86df1fd5 before this review. That release workflow now calls actions/chocolatey-render, which replaces both URL placeholders and checks the packed package for leftovers. Its Google gro/grw fixtures passed CI in .github#48. The package remains gated on the cfl Business internalization check.

$urlArm64 = 'URL_ARM64_PLACEHOLDER'
$checksumAmd64 = 'CHECKSUM_AMD64_PLACEHOLDER'
$checksumArm64 = 'CHECKSUM_ARM64_PLACEHOLDER'

if ($env:PROCESSOR_ARCHITECTURE -eq 'ARM64') {
$arch = 'arm64'
$url = $urlArm64
$checksum = $checksumArm64
} elseif ([Environment]::Is64BitOperatingSystem) {
$arch = 'amd64'
$url = $urlAmd64
$checksum = $checksumAmd64
} else {
throw "32-bit Windows is not supported. grw requires 64-bit Windows."
}

$url = "https://github.com/open-cli-collective/google-cli/releases/download/v${version}/grw_v${version}_windows_${arch}.zip"

Install-ChocolateyZipPackage -PackageName $env:ChocolateyPackageName `
-Url $url `
-UnzipLocation $toolsDir `
Expand Down
Loading