Repository navigation
feat: hide advanced inputs behind More options in the run form - #15
Merged
Merged
Conversation
An input with advanced: true stays out of the run form until More options is opened, and runs with its default otherwise. The CLI still sets it with --input, and lest get marks it. A required advanced input must have a default so the form can start without it.
Member
Author
|
Review pass on the diff (self-review; no findings needing a change):
|
# Conflicts: # crates/lest-core/src/validate.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flows often carry inputs that most runs leave at their default (a tenant, a region, a fixture id). Showing all of them in the run form makes the form noisy.
advanced: truekeeps such an input behind More options:aria-expanded).--input tenant=globexsets an advanced input from the CLI like any other.lest getmarks advanced inputs.default, so the form can always start without opening More options.Verification
an_advanced_required_input_needs_a_default, new UI tests forformInputs.lest uiwith Playwright: closed form showsgreetingand More options (2); opened, it showsgreeting | Tenant | region.lest run hello --input tenant=globex --input region=uspasses.make lint,make build, UI tests and all Rust tests pass exceptparallel_group_runs_concurrentlyandcancel_stops_steps_but_runs_finally_and_cleanup, which fail the same way onmainon this machine under load (timing assertions); CI is the reference.