Repository navigation
feat: name a flow's newest run with --flow - #19
Merged
Merged
Conversation
runs get, cleanup, bundle, explain and context take --flow <id> in place of a run id, meaning that flow's newest run, so replaying cleanups or bundling evidence after a run no longer needs the id copied from its output.
Member
Author
|
Review pass on the diff (self-review):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commands that act on a past run need its id, which means copying it from the run's output. They now also take
--flow <id>, meaning that flow's newest run:runs get,cleanup,bundle,explainandcontextthrough oneRunRefargument group: exactly one of a run id or--flow(clap enforces it).Verification
a_run_is_named_by_id_or_by_flow(by id, by flow, neither, both).scripts/e2e.shnow runslest runs get --flow wrong-passwordand checks it returns the failed run, andlest bundle --flow plants-api. The script passes locally.make lintandmake buildpass.