You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
as of otel api 1.67.0, AttributesBuilder.putAll logs a warning if passed null. both TracesHook and MetricsHook call AttributesBuilder.putAll in their after and error methods, so if any of the Hooks' attribute options produced null, it would trigger this warning log. the PR prevents those logs by ensuring Attributes.putAll is never called with a null argument.
How to test
Relevant tests have been added to the existing junit suite.
Review was skipped as selected files did not have any reviewable changes.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: a0f082c5-d652-48cc-9815-592813548eb3
Commits
Reviewing files that changed from the base of the PR and between af5c24c and 69712a6.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
MetricsHook and TracesHook now handle null extra attributes and null results from attribute extractors. Parameterized tests capture warning-level and higher log messages for several option configurations.
Both hooks use empty attributes when extra attributes are null. Their after methods add extracted attributes only when the extractor returns a non-null value.
Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly summarizes the main change: preventing OpenTelemetry warning logs caused by null attributes.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description states the PR fixes OpenTelemetry warning logs caused by AttributesBuilder.putAll receiving null attributes in TracesHook and MetricsHook. It names the affected after and error methods…
Full details: Description check
Explanation
The description states the PR fixes OpenTelemetry warning logs caused by AttributesBuilder.putAll receiving null attributes in TracesHook and MetricsHook. It names the affected after and error methods, the cause (otel api 1.67.0), the fix (never call putAll with null), and the added tests. This matches the changeset, which guards null attributes in both hooks and adds tests that assert no warnings are logged.
Full details: Docstring Coverage
Explanation
Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 4 functions across 4 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 89e7f752-5521-45c2-91e0-5abef3ec4778
Commits
Reviewing files that changed from the base of the PR and between a91a790 and f08c16c.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
as of otel api 1.67.0, AttributesBuilder.putAll logs a warning if passed
null. both TracesHook.after and TracesHook.error call AttributesBuilder
.putAll, so if TracesHookOptions.extraAttributes is left as its null
default, or set to null explicitly, or the provided dimensionExtractor
returns null it triggers this warning log. to avoid this, TracesHook
uses Attributes.empty if passed an options instance with a null
extraAttributes field, and checks if the extractor produced null before
adding the result.
Signed-off-by: rafearnold <rafe.arnold@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aepfli
left a comment
This PR
as of otel api 1.67.0, AttributesBuilder.putAll logs a warning if passed null. both TracesHook and MetricsHook call AttributesBuilder.putAll in their after and error methods, so if any of the Hooks' attribute options produced null, it would trigger this warning log. the PR prevents those logs by ensuring Attributes.putAll is never called with a null argument.
How to test
Relevant tests have been added to the existing junit suite.