Skip to content

feat(otlp): support vsock gRPC endpoints - #4740

Open
Amanpal9 wants to merge 8 commits into
open-telemetry:mainfrom
Amanpal9:support-vsock-otlp-grpc
Open

Amanpal9 wants to merge 8 commits into
open-telemetry:mainfrom
Amanpal9:support-vsock-otlp-grpc

Conversation

@Amanpal9

@Amanpal9 Amanpal9 commented Oct 27, 2026 •

Copy link
Copy Markdown

Fixes #4706

Add support for Linux VSOCK endpoints in the OTLP gRPC exporter. Convert vsock://<cid>:<port> endpoints to the vsock:<cid>:<port> target format expected by gRPC, and pass raw vsock:<cid>:<port> targets through unchanged.

Document the supported endpoint forms and note the gRPC version requirement.

Validation:

  • git diff --check passed.
  • Local C++11 URL parser smoke assertions passed for VSOCK port 100000, maximum 32-bit port, 32-bit overflow rejection, and HTTP port 65536 rejection.
  • Full CMake/GoogleTest/gRPC test targets were not run locally because these tools/dependencies are unavailable. GitHub Actions runs for the new head currently require approval.

@Amanpal9
Amanpal9 requested a review from a team as a code owner October 27, 2026 04:24
@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

Comment thread exporters/otlp/src/otlp_grpc_client.cc Resolved
@lalitb lalitb added the pr:waiting-on-cla Waiting on CLA label Oct 27, 2026
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.60%. Comparing base (23786b7) to head (145f833).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4740      +/-   ##
==========================================
+ Coverage   86.60%   86.60%   +0.01%     
==========================================
  Files         530      530              
  Lines       21010    21014       +4     
==========================================
+ Hits        18194    18198       +4     
  Misses       2816     2816              
Files with missing lines Coverage Δ
exporters/otlp/src/otlp_grpc_client.cc 71.43% <100.00%> (+0.38%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lalitb lalitb removed the pr:waiting-on-cla Waiting on CLA label Oct 27, 2026

@lalitb lalitb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amanpal9 - thanks for the PR. Could we also support ports above 65535 for vsock:// endpoints? VSOCK uses 32-bit ports, but the HTTP URL parser still rejects them. Please add a test for say vsock://3:100000.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support vsock transport in OTLP gRPC client

2 participants