Repository navigation
scripts: Add an isolated eachdist environment - #5783
Open
Harshil-1603 wants to merge 7 commits into
Open
Harshil-1603 wants to merge 7 commits into
Harshil-1603 wants to merge 7 commits into
Conversation
Refs: open-telemetry#4277 Assisted-by: OpenAI gpt-6.1-sol
Assisted-by: OpenAI gpt-6.1-sol
Assisted-by: OpenAI gpt-6.1-sol
Assisted-by: OpenAI gpt-6.1-sol
Assisted-by: OpenAI gpt-6.1-sol
Pull request dashboard statusWaiting on maintainers · refreshed 2026-10-18 03:35 UTC Merge when ready. Status above doesn't look right?
|
herin049
requested changes
Oct 16, 2026
github-project-automation
Bot
moved this to Reviewed PRs that need fixes
in Python PR digest
herin049
reviewed
Oct 16, 2026
Pin toml in dev-requirements.txt and use it as the constraints file for the isolated tox environment and release dependency installation. Remove the redundant requirements file and unneeded changelog fragment as requested in review. Assisted-by: OpenAI Codex (GPT-6)
Keep the existing toml pin alongside the upstream testcontainers addition. Preserve all other upstream changes. Assisted-by: OpenAI Codex (GPT-6)
herin049
approved these changes
Oct 18, 2026
github-project-automation
Bot
moved this from Reviewed PRs that need fixes
to Approved PRs
in Python PR digest
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused tooling and documentation changes are consistent, with no unresolved findings.
No open issues 🎉
What changed in this PR
Adds an isolated tox environment for eachdist, addressing #4277 without changing runtime packages.
Changes:
- Pins
tomlin shared development constraints used by tox and the release workflow. - Adds and documents
tox -e eachdist -- <arguments>.
| File | Description |
|---|---|
| tox.ini | Adds an isolated eachdist environment. |
| dev-requirements.txt | Pins toml to 0.10.2. |
| CONTRIBUTING.md | Documents invocation with an example. |
| .github/workflows/release.yml | Installs toml using shared constraints. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pin the eachdist dependency in a dedicated requirements file, add a tox environment for running the tool, and use the same requirements in the release workflow. Document how contributors can run eachdist without installing its dependencies into another environment.
Fixes #4277.
Type of change
Validation
tox -e eachdist -- version --mode stablepassed and returned1.46.0.dev.tox -e ruffpassed, including pre-commit formatting/lint and the lockfile check.AI assistance: OpenAI Codex, gpt-6.1-sol.