Repository navigation
Keep a measure break's flag through the schedule - #172
Open
dcharlot65-openie wants to merge 5 commits into
Open
dcharlot65-openie wants to merge 5 commits into
dcharlot65-openie wants to merge 5 commits into
Conversation
The scheduled core of fn table rebuilt the break arm's false as a capture of the output dummy, so the gate no longer saw a fresh literal on that arm. A bool written after the arm has computed something is a node of the arm. A literal the arms only return is named by one let in the parent, and only the arm uses that local, so a later sum.mk still has a literal index. Co-authored-by: David Charlot <dcharlot65-openie@users.noreply.github.com>
`fn freq` adds one to `(m.get(w) catch 0)` where the map values are u32. The handler is a literal, so the typed tree kept both the `lit` name and `u32`, and the sum had two check ranges. Catch already requires the handler to have the success type, so a literal handler takes that name and the sum is checked against u32. The file lowers. `fn freq` still fails FG8 at node 3. Co-authored-by: David Charlot <dcharlot65-openie@users.noreply.github.com>
…mpty. A pure break arm captured the parent's dummy false, so FG8 did not see a literal in that region. mfind's search loop is that arm: the key is past the probe and the index is not stepped. The arm now stores a fresh false with no inputs, and a captured bool is a node of the arm. The measure applies, and the schedule reads mfind back as the same bytes. A list singleton's catch initial is list.new. Both arms that run drop it and store the real sum. An array still has no dummy. 21_maps.rce is no longer FG8. Its root is round-trip, because the decimal helpers' empty text does not come back as the same nodes. The whole module's first refusal is exit. Co-authored-by: David Charlot <dcharlot65-openie@users.noreply.github.com>
The acceptance gate on main does not change the schedule of a measure break. Co-authored-by: David Charlot <dcharlot65-openie@users.noreply.github.com>
The witness checks that the break is the loop flag and that the schedule reads that form back. The old name still said the schedule was refused. Co-authored-by: David Charlot <dcharlot65-openie@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main at
86b8efcfis merged in an ordinary merge (26e47efa). There were no conflicts. The acceptance gate on main does not change the schedule of a measure break. PR 160's literal-placement rule is not in this branch.The witness that still said a
break 1inside a block was refused isa_break_that_names_the_loop_from_inside_a_block_round_trips. It asserts that the break is the loop flag and that the schedule reads that form back. The round-trip tags on21_maps.rce(fn freq),33_in_operator.rce, and43_simd_lanes.rceare unchanged. No program root's first tag is FG8.The gate is not changed.
Schedule of
fn tableThe scheduled core rebuilt the break arm's
falseas a capture of the output dummy, so FG8 no longer saw a fresh literal on that arm. A bool an arm returns is a node of that arm, including a pure break. A literal the arms only return is onelet, and only the arm uses that local, so a latersum.mkstill has a literal index. The1underint.bad.addstays an atom.fn table, lowered on its own, round-trips.body_break_rewritestays set. Core eval, Form eval, and the scheduled core oftable()are(a, 1), (b, 2). It does not enter the syntactic floor.fn freqlowers(m.get(w) catch 0) + 1with map valuesu32kept both thelitname andu32, so the sum had two check ranges and the file did not lower. Catch already requires the handler to have the success type. A literal handler takes that name. The sum is checked againstu32. The reference trace of21_maps.rce, including probes, matches the lowered core.fn freq's search breakmfind's second break is a purebreakof the search loop. The key is past the probe, so the arm does not step the index. Construction returned that flag as a capture of the parent's dummyfalse. FG8 reads a literal false in the same region, sofn freqfailed at node 3. The arm now stores a fresh false with no inputs.mfindround-trips.fn freq's closure constructs, and the schedule constructs, so the file is not FG8.The closure's bytes are not identical. The decimal helpers' empty text is the same bits as a branch output's dummy, and the schedule reads that node back in the parent. The root tag is
round-trip. This is a loop-body break, not PR 160's non-loop block break.List catch
A list singleton's initial value is
list.newof the element. Both arms that run drop it and store the real sum. An array singleton still has no dummy.observe fn tableno longer refuses withcatch. The whole module's first refusal isexit.Census
Floor, whole, and option B are unchanged. No program root's first tag is FG8. The merge and the rename do not move these rows. Head
fd9e0056matches the0208c624column.9ef5c387c384351c0208c624andfd9e0056breakcatchFG833_in_operator.rce21_maps.rce,33_in_operator.rcebreakcatchglobaloutFG843_simd_lanes.rce43_simd_lanes.rce43_simd_lanes.rceisround-trip)21_maps.rcelitmixed withu32)FG8atfn freqnode 3; whole setcatch,exitround-trip; whole setexitThe nine mismatch names stay in the first-tag
round-triplist on every revision above:03_fib_loop.rce,10_comptime.rce,22_tuples.rce,25_labels.rce,36_multiline_brackets.rce,43_simd_lanes.rce,45_byte_text.rce,46_u64.rce,49_loop_limit.rce.21_maps.rceand33_in_operator.rcejoin that list on0208c624and stay there onfd9e0056.Overlap with PR 160
PR 160 is still open. This branch does not rewrite a standalone block break. Both edit
schedule_branch. A later merge of PR 160 will conflict there. This merge of main does not take PR 160's literal-placement rule.Not merged. Not deployed.