Repository navigation
Run the long checker binaries in their own CI jobs - #176
Open
dcharlot65-openie wants to merge 1 commit into
Open
dcharlot65-openie wants to merge 1 commit into
dcharlot65-openie wants to merge 1 commit into
Conversation
cargo test runs one binary at a time. On main 9ef5c38, form_bridge, break_fg8_witness and emit_run took about 21 minutes inside tests-fast, which is why that step and the tree-sitter feature suite approached the job limit. Each binary still runs with and without the tree-sitter feature. No test is dropped. Co-authored-by: David Charlot <dcharlot65-openie@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #175.
Summary
tests-fastandchecker (tree-sitter)spend most of their time in three release binaries thatcargo testruns one after another. On main9ef5c387(run 42818858124) cargo reportedform_bridge519.3 s,break_fg8_witness424.8 s andemit_run305.2 s, about 20.8 minutes of a 32.03 minute Fast tests step. The same three binaries are why the tree-sitter feature suite reached 35.82 minutes on run 42818858285, and why pull request 160 reached 53.65 minutes (push) and 54.55 minutes (pull_request) on commit069cf029.Release compile stayed about 3 to 5 minutes, and the two feature jobs on
069cf029hit the samerust-cachekey. The cache is not what makes the step long.This change puts those three binaries on the existing slow-job matrix.
ci.ymlruns each one without the tree-sitter feature.tree-sitter syncruns each one with that feature, in its own job.scripts/ci-tests.sh faststill runs every other binary, including the library tests andgrammar_fuzz. Nothing is filtered, ignored, or removed. No timeout is raised. The 60 minute limits stay as they are.Tests
bash -non both scripts,scripts/ci-tests.sh slow-list,scripts/check-flags.pyandscripts/check-removed-paths.pypassed. Thetests-slowmatrix matches the slow list. The checker suite itself is unchanged and runs in CI.