Repository navigation
Keep a literal binding distinct from a dummy with the same bits - #178
Open
dcharlot65-openie wants to merge 1 commit into
Open
dcharlot65-openie wants to merge 1 commit into
dcharlot65-openie wants to merge 1 commit into
Conversation
A var or let of a literal reused a capture of those bits. The decimal helpers' empty text is that binding, and a branch output's dummy is the same bytes, so the schedule read the text back in the parent. The binding is now its own node. An operand still shares a capture, so a domain test and the operation it guards stay one value. fn freq's closure round-trips. 21_maps.rce is option B. Its whole module is still exit. Co-authored-by: David Charlot <dcharlot65-openie@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
varorletof a literal reused a capture when the bits matched. The decimal helpers infn freqbind empty text that way. The branch that returns the text also has a dummy initial of empty text. The schedule read the binding back as that parent dummy, soconstruct(schedule(F))was not F. The gate was not the cause: both forms constructed.A binding is now its own node. A literal already built in the same region is still that node. An operand still shares a capture, so a domain test and the operation it guards stay one value. FG7, FG8, and C7 are unchanged.
fn freq's closure round-trips.21_maps.rceis option B. The whole module's first refusal is stillexit.The same distinction clears other closures whose mismatch was a binding and a dummy of the same bits. The syntactic floor stays 5. Four more modules schedule back wholly:
08_traits.rce,18_while_bound.rce,24_lambda.rce,27_bitops.rce.Census
0208c624ec6a6d23breakcatchFG8defect22_tuples.rceis now the file's first tag)round-trip21_maps.rceexit; rootsround-tripexit; rootsclear(option B)First-tag
round-tripon0208c624:03_fib_loop.rce,08_traits.rce,10_comptime.rce,11_arena.rce,18_while_bound.rce,19_floats.rce,21_maps.rce,22_tuples.rce,24_lambda.rce,25_labels.rce,27_bitops.rce,28_slices.rce,33_in_operator.rce,36_multiline_brackets.rce,41_arena_bound_wrapping.rce,43_simd_lanes.rce,45_byte_text.rce,46_u64.rce,49_loop_limit.rce.First-tag
round-triponec6a6d23:10_comptime.rce,11_arena.rce,19_floats.rce,28_slices.rce,33_in_operator.rce,41_arena_bound_wrapping.rce.Of the nine names that were in that list on both earlier revisions,
03_fib_loop.rce,25_labels.rce,36_multiline_brackets.rce,43_simd_lanes.rce,45_byte_text.rce,46_u64.rce, and49_loop_limit.rceare now option B.10_comptime.rcestaysround-trip.22_tuples.rce's first tag isdefectbecause an older refusal is now the first one. The defect itself is unchanged. See below.22_tuples.rceis case (b)The file has two program roots.
fn divmodsorts first. The file's first tag is that root's refusal, or the next root's iffn divmodapplies.On
0208c624,fn divmodconstructs and its schedule constructs. The bytes differ, so the tag isround-trip. There is no defect on that root.fn use_itis the next root. Its schedule refuses, on that same revision:requires change schedule -: defect: the schedule is not well formed: in ac28239692a3f0a647c19ea503e3d46a640e6487f3ae6d125209e2ee06b0beb3/0: W3: the paths that meet after an if hold different owned values ({1: Live, 3: Dead, 4: Live} and {1: Dead, 3: Dead, 4: Live})On
ec6a6d23,fn divmodround-trips (construct(schedule(F))is F).fn use_itrefuses with that same sentence, including the same group key and the same live and dead sets. The defect was already reachable by schedulingfn use_itdirectly. It was not the file's first tag whilefn divmodstill mismatched.Not merged. Not deployed. PR 172's branch is untouched.