Skip to content

Support discriminator for polymorphic types and support oneOf #219

Closed
#1154
Closed
Support discriminator for polymorphic types and support oneOf#219
#1154
Labels
✨ enhancementNew feature or improvement🍭 OpenAPI ComplianceSupporting a new bit of the OpenAPI spec

Description

@bowenwr
bowenwr
opened on Oct 16, 2020

Is your feature request related to a problem? Please describe.

When an endpoint returns oneOf several different classes, currently it returns an empty object. Sample component snippet:

    ReturnedObject:
      oneOf:
        - $ref: '#/components/schemas/PolymorphicType'
        - $ref: '#/components/schemas/AnotherPolymorphicType'

Describe the solution you'd like

Support discriminators to be able to deserialize polymorphic types.

Activity

  1. bowenwr
    added
    ✨ enhancementNew feature or improvement
    on Oct 16, 2020

  2. dbanty commented on Nov 14, 2020

    @dbanty
    dbanty
    on Nov 14, 2020
    Collaborator

    I tested this with the latest code on main (roughly 0.7.0-rc.1) and it does attempt to generate proper responses now using the same code it would for unions inside a model (basically a series of try/except). So it's better than nothing, though for sure we still should add discriminators in a future version.

  3. dbanty
    added
    🍭 OpenAPI ComplianceSupporting a new bit of the OpenAPI spec
    on Aug 13, 2023
  4. openapi-generators
    locked and limited conversation to collaborators on Aug 13, 2023
  5. dbanty
    converted this issue into a discussion #830 on Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ✨ enhancementNew feature or improvement🍭 OpenAPI ComplianceSupporting a new bit of the OpenAPI spec

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions