Skip to content

Tell openapi-python-client update to not change certain folders/packages #640

Closed
Closed
Tell openapi-python-client update to not change certain folders/packages#640
Labels
✨ enhancementNew feature or improvement

Description

@adelevie
adelevie
opened on Jun 29, 2022

When I run:

openapi-python-client update --path apispec.yaml

A custom folder, util is deleted.

I'd like to have an option where update will ignore the util folder.

I've considered somehow bundling the util folder outside of the package, but I really want something where it's straightforward to distribute some higher level code built on top of the really nice generated code.

Activity

  1. adelevie
    added
    ✨ enhancementNew feature or improvement
    on Jun 29, 2022

  2. adelevie commented on Jun 29, 2022

    @adelevie
    adelevie
    on Jun 29, 2022
    ContributorAuthor

    Looks like this line could be replaced https://github.com/openapi-generators/openapi-python-client/blob/main/openapi_python_client/__init__.py#L130 with something that either:

    1. explicitly only deletes known folder names (e.g. only models and only api), OR

    2. deletes everything except some allow-listed folder names

  3. adelevie commented on Jun 30, 2022

    @adelevie
    adelevie
    on Jun 30, 2022
    ContributorAuthor

    here's a short proof of concept:

    #641

  4. dbanty commented on Jul 2, 2022

    @dbanty
    dbanty
    on Jul 2, 2022
    Collaborator

    Related to #454 I think

  5. adelevie commented on Jul 2, 2022

    @adelevie
    adelevie
    on Jul 2, 2022
    ContributorAuthor

    Absolutely related, thanks for pointing out.

    Happy to try and take my proof concept across the finish line, but also not sure what the desired developer experience is.

    I do like the "ignore" terminology in #454, for what it's worth.

  6. openapi-generators
    locked and limited conversation to collaborators on Aug 13, 2023
  7. dbanty
    converted this issue into a discussion #812 on Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ✨ enhancementNew feature or improvement

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions