refactor(xml): move insert_in_sequence into xml_util - #941
Merged
Merged
Conversation
The odf style writer ordered the properties of a style with its own copy of `insert_in_sequence`, which only the ooxml writers could reach. The helper now sits in `xml_util` beside `set_attribute`, so the odf and the ooxml writers share one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tigcf9he3w1aHfNPJoEGsd
`write_run_properties` in the pptx writer had its own copy of `set_attribute`, so its lambda now calls the shared one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tigcf9he3w1aHfNPJoEGsd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Change
insert_in_sequencemoves fromooxml_utiltoxml_util, besideset_attribute. The odf and ooxml writers now share one copy.properties_ofhad its own copy of the same ordered insert, because the odf code cannot reachooxml_util. It now callsxml::insert_in_sequence. Both copies rank a child the sequence does not name last, so the order does not change.write_run_propertieshad its own copy ofset_attributein a lambda. It now callsxml::set_attribute(second commit).xml/AGENTS.mdandooxml/AGENTS.mdsay where the helpers now live.Proof
-Wall -Wextra -Werror.