Feat/add kwargs setups evaluations - #1754
Open
shellyco-code wants to merge 8 commits into
Open
shellyco-code wants to merge 8 commits into
shellyco-code wants to merge 8 commits into
Conversation
Signed-off-by: Shelly Chahar <shellychahar57@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1754 +/- ##
===========================================
- Coverage 81.50% 53.92% -27.58%
===========================================
Files 63 63
Lines 5238 5242 +4
===========================================
- Hits 4269 2827 -1442
- Misses 969 2415 +1446 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…om/shellyco-code/openml-python into feat/add-kwargs-setups-evaluations
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
**kwargssupport tolist_setupsandlist_evaluationsDetails
What does this PR implement/fix? Explain your changes.
Added
**kwargssupport to bothlist_setupsandlist_evaluationsso we can pass extra filters down to the backend. I also cleaned up the old TODO comments intest_utils.pythat were pointing out they were missing.Why is this change necessary? What is the problem it solves?
It was a bit frustrating that some list endpoints supported kwargs for extra query params but these two didn't. This just brings them inline with the rest of the API and keeps things consistent.
How can I reproduce the issue this PR is solving and its solution?
Try passing an extra filter like
openml.setups.list_setups(uploader=1). Before this, it would throw aTypeError. Now it passes it through correctly.