Skip to content

Feat/add kwargs setups evaluations - #1754

Open
shellyco-code wants to merge 8 commits into
openml:mainfrom
shellyco-code:feat/add-kwargs-setups-evaluations
Open

shellyco-code wants to merge 8 commits into
openml:mainfrom
shellyco-code:feat/add-kwargs-setups-evaluations

Conversation

@shellyco-code

Copy link
Copy Markdown
Contributor

Metadata

Details

  • What does this PR implement/fix? Explain your changes.
    Added **kwargs support to both list_setups and list_evaluations so we can pass extra filters down to the backend. I also cleaned up the old TODO comments in test_utils.py that were pointing out they were missing.

  • Why is this change necessary? What is the problem it solves?
    It was a bit frustrating that some list endpoints supported kwargs for extra query params but these two didn't. This just brings them inline with the rest of the API and keeps things consistent.

  • How can I reproduce the issue this PR is solving and its solution?
    Try passing an extra filter like openml.setups.list_setups(uploader=1). Before this, it would throw a TypeError. Now it passes it through correctly.

@codecov-commenter

codecov-commenter commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.92%. Comparing base (4a25027) to head (a9d98d4).

Files with missing lines Patch % Lines
openml/_api/resources/setup.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1754       +/-   ##
===========================================
- Coverage   81.50%   53.92%   -27.58%     
===========================================
  Files          63       63               
  Lines        5238     5242        +4     
===========================================
- Hits         4269     2827     -1442     
- Misses        969     2415     +1446     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Add missing **kwargs support to list_setups and list_evaluations

2 participants