Repository navigation
Option to enable OpenTelemetry agent on manager JVM - #3218
Conversation
…structions for both docker compose and kubernetes
There was a problem hiding this comment.
I would move these README.md changes to the documentation website itself, wherever suitable.
There was a problem hiding this comment.
I added some documentation, see openremote/documentation#193
But I think it makes sense to keep more details here and have the public doc more a "How to" guide.
I'll review/improve the public doc as we're progressing with using all the "Grafana" features on the different projects and moving to a more stable situation.
There was a problem hiding this comment.
I think it makes sense to mention that we're using OpenTelemetry etc in the README.md.
However, once we're explaining how it works, I'd rather hyperlink it to the docs.
(similar to all other tools/agents we're using)
There was a problem hiding this comment.
I also noticed most of the "technical information" of the repo isn't inside the README.md file,
but on the docs introduction page; https://docs.openremote.io/docs/introduction
There was a problem hiding this comment.
I remove extra information from README file in project, pointed to documentation website and added what I thought was still useful to the documentation page.
| nimbusJoseJwt = "10.9.1" | ||
| objenesis = "3.5" | ||
| moquette = "0.18.0" | ||
| opentelemetryJavaagent = "2.30.0" |
Co-authored-by: Wouter Born <github@maindrain.net>
|
MartinaeyNL
left a comment
MartinaeyNL
left a comment
There was a problem hiding this comment.
Let's merge this. We can always bump the OpenTelemetry version later 👍
(I also assume dependabot will detect it haha)
3 participants
See README.md for some of the validation steps.
Some extra setup / test information has been kept in that file as I thought it made sense to keep it as background info.