Repository navigation
Migrate another set of UI dialogs to or-vaadin-dialog - #3265
MartinaeyNL wants to merge 47 commits into
Conversation
…aadin-checkbox-group
…r-vaadin-checkbox-group
…. Fix for attribute list in group asset not being sorted nor formatted.
…in the delete realm dialog.
…rn on this issue.
…asset selection in Insights
|
The PR is ready to review 👍 It's quite an extensive one, although most of the file changes are very similar; Let me know if anything needs to be clarified 😉 |
There was a problem hiding this comment.
The following dialogs have been missed (excluding those from #3371):
ui/component/or-map/src/index.ts:233(location dialog for the attribute input; compact-mode map modal ingeoJsonPointInputTemplateProvider)ui/app/manager/src/pages/page-export.ts:444(attribute picker for selecting what to export)ui/app/manager/src/pages/page-gateway.ts:547(data-sharing selected attributes; asset-type picker behind the "N attributes selected" button)ui/component/or-attribute-card/src/index.ts:491-505(single-attribute picker for the KPI card)ui/component/or-chart/src/index.ts:1225(multi-select picker for adding attributes to a chart)ui/component/or-dashboard-builder/src/panels/attributes-panel.ts:287, 360, 369(three pickers:replaceWidgetAttribute, andopenAttributeSelectorwith and without pre-selected attributes)ui/component/or-rules/src/flow-viewer/components/internal-picker.ts:197(single-select picker for the flow editor's asset attribute input)ui/component/or-attribute-picker/src/attribute-picker.ts:44(AttributePicker extends OrMwcDialog; blocks 2 through 7, which are only call sites)ui/app/insights/src/components/dashboard-menu.ts:139(realm switcher in the Insights app; one dialog action per realm)ui/component/or-app/src/index.ts:186, 430(<or-mwc-dialog id="app-modal">host element andOrMwcDialog.DialogHostElement; remove once 1 through 9 are done, along with the side-effect import inor-app/src/or-header.ts:33, the barrel export inor-mwc-components/src/index.ts:19, and the fixture inor-mwc-components/test/fixtures/index.ts:58-61)
@Ekhorn for your information; I've left the |
…ation to what is on main branch
|
|
I've still got a few things to address. Putting it back to draft temporarily. |



Description
This PR migrates another set of
<or-mwc-dialog>Material dialogs to the new Vaadin<or-vaadin-dialog>dialogs.Many of the dialogs are familiar, but also less-often used features of the platform are worth transferring to the new format.
After this, only the attribute picker dialogs are left to migrate, see #3414
See the changelog below for a full list of changes.
Changelog
<or-vaadin-dialog>.<or-vaadin-dialog>.<or-vaadin-dialog>.<or-vaadin-dialog>.<or-vaadin-dialog>.<or-vaadin-dialog>.<or-vaadin-dialog>.<or-vaadin-dialog>.<or-vaadin-dialog>.<or-vaadin-confirm-dialog>.<or-vaadin-dialog>.<or-vaadin-confirm-dialog>.<or-vaadin-dialog><or-vaadin-dialog>Checklist
1. Acceptance criteria of the linked issue(s) are met4. Documentation is written or updated