Validate against max resolution before image generation by kbalka · Pull Request #4645 · openvinotoolkit/model_server

kbalka · 2026-10-09T12:03:38Z

🛠 Summary

CWE-770
Fix for image generation api to validate requested size against configured maxResolution

🧪 Checklist

Unit tests added.
[not needed] The documentation updated.
Change follows security best practices.
``

…_max_resolution

Copilot

🟡 Changes recommended

Single-dimension requests bypass the security limit, and several tests fail due to zero-initialized limits.

3 open findings

Initialize maxResolution in static-mode fixtures · New
Validate supplied width and height independently · New
Use the standard default maximum when maxRes is null · New

What changed in this PR

Adds configured maximum-resolution validation to image generation and editing requests.

Changes:

Extracts shared request validation.
Rejects dimensions exceeding maxResolution.
Adds maximum-resolution unit tests.

File	Description
`src/image_gen/imagegenutils.cpp`	Adds shared dimension-limit validation.
`src/test/text2image_test.cpp`	Adds resolution boundary tests.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…_max_resolution

Copilot

🟡 Changes recommended

Automatic or omitted dimensions can bypass the configured maximum-resolution cap.

3 open findings

Enforce max resolution for auto or omitted sizes · New
Initialize maxResolution in static-mode fixtures
Correct misleading static reshape validation debug message · New

2 resolved since last review

Validate supplied width and height independently
Use the standard default maximum when maxRes is null

🧠 Review effort: Balanced

Copilot

🟢 Approval recommended

The validation is consistently applied across request modes and is adequately covered by focused tests.

2 open findings

1 resolved since last review

Correct misleading static reshape validation debug message

🧠 Review effort: Balanced

… common max validation

Copilot

🔵 Needs a closer look

Static requests bypass existing limits, and image-edit requests can still evade native-resolution validation.

0 open findings

2 resolved since last review

Previously missed (1)

In code that hasn't changed since last review

Static requests bypass general option validation and defaults

src/image_gen/imagegenutils.cpp:341

This early return skips ensureAcceptableForDynamic, which now contains checks and defaulting that previously ran for every request mode. Static requests can therefore bypass the num_inference_steps bounds (and the image-count bounds) and no longer receive defaultNumInferenceSteps. Run those general option checks after the static-shape validation instead of returning here.

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

Image-edit requests can still bypass the maximum-resolution limit when no explicit or configured default size is present.

0 open findings

Previously missed (1)

In code that hasn't changed since last review

Image edits bypass max-resolution validation at native size

src/image_gen/imagegenutils.cpp:435

The native-resolution fallback is only applied to create requests. getImageEditRequestOptions() still leaves width/height absent when no defaultResolution is configured, so an /images/edits request with an omitted or auto size passes ensureCommonValidations() without any max-resolution check and GenAI can generate at its native resolution even when that exceeds maxResolution. Please capture and validate the effective native resolution for image-to-image/inpainting requests as well, with multipart regression coverage.

🧠 Review effort: Balanced

Copilot

🟢 Approval recommended

The resolution limit is consistently enforced before generation with adequate boundary and regression coverage.

0 open findings

🧠 Review effort: Balanced

atobiszei · 2026-10-12T14:23:44Z

    // the priority chain (request > composite > individual adapter) determines the effective value.
    using CompositeLoraMap = std::unordered_map<std::string, std::vector<std::pair<std::string, std::optional<float>>>>;
    CompositeLoraMap compositeLoraAdapters;
+    std::optional<resolution_t> nativeResolution;


Minor:
keep resolution fields together? And add default value for:DEFAULTIMAGE_GEN_ARGS

atobiszei · 2026-10-12T14:29:05Z

+        if (nativeConfig.width <= 0 || nativeConfig.height <= 0) {
+            throw std::runtime_error("Failed to determine model-native image generation resolution");
+        }
+        this->args.nativeResolution = resolution_t{nativeConfig.width, nativeConfig.height};


We should add validation (rejection or warning), where nativeResolution > maxResolution, and maxResolution is set.

atobiszei · 2026-10-12T14:37:44Z

+TEST(Text2ImageTest, validateForStaticReshapeSettings_ExceedsDefaultMaxResolution) {
+    ImageGenPipelineArgs args = DEFAULTIMAGE_GEN_ARGS;
+    args.modelsPath = "/ovms/src/test/dummy";
+    args.staticReshapeSettings = ovms::StaticReshapeSettingsArgs({{5000, 512}});
+
+    std::string value = R"({"prompt": "test prompt", "size": "5000x512", "n": 1, "model": "test model"})";
+    ovms::HttpPayload payload;
+    payload.parsedJson = std::make_shared<rapidjson::Document>();
+    payload.parsedJson->Parse(value.c_str());
+    ASSERT_FALSE(payload.parsedJson->HasParseError());
+
+    auto requestOptions = ovms::getImageGenerationRequestOptions(*payload.parsedJson, args);
+    ASSERT_TRUE(std::holds_alternative<absl::Status>(requestOptions));
+    EXPECT_THAT(std::get<absl::Status>(requestOptions).message(), ::testing::HasSubstr("exceeds maxResolution"));
 }


We shoudl also test for getImageGenerationRequestOptions with nativeResolution set above max and missing size in request?

Validate agains max resolution before image generation

36ba3c4

Copilot AI balanced review requested due to automatic review settings October 9, 2026 12:03

Merge branch 'main' into kbalka_fix_CWE_770_validate_requested_res_vs…

1d2c976

…_max_resolution

Copilot started reviewing on behalf of kbalka October 9, 2026 12:04 View session

Copilot AI reviewed Oct 9, 2026

View reviewed changes

Comment thread src/image_gen/imagegenutils.cpp

Comment thread src/image_gen/imagegenutils.cpp

Comment thread src/test/text2image_test.cpp Outdated

kbalka added 5 commits October 9, 2026 17:09

Squash this

d424200

Style

adeb3e8

Move max res validation to common

b39de09

Fix style

6d2398c

Merge branch 'main' into kbalka_fix_CWE_770_validate_requested_res_vs…

3fa7c83

…_max_resolution

kbalka requested a balanced review from Copilot October 9, 2026 15:12

Copilot started reviewing on behalf of kbalka October 9, 2026 15:13 View session

Copilot AI reviewed Oct 9, 2026

View reviewed changes

Comment thread src/image_gen/imagegenutils.cpp

Comment thread src/image_gen/imagegenutils.cpp Outdated

kbalka added 2 commits October 12, 2026 09:07

Fix debug log

d953731

Fix copilot findings

408db21

kbalka requested a balanced review from Copilot October 12, 2026 07:42

Copilot started reviewing on behalf of kbalka October 12, 2026 07:44 View session

Copilot AI reviewed Oct 12, 2026

View reviewed changes

Use native resolution size unspecified and defaults not exits, before…

637df21

… common max validation

kbalka requested a balanced review from Copilot October 12, 2026 12:04

kbalka changed the title ~~Validate agains max resolution before image generation~~ Validate against max resolution before image generation Oct 12, 2026

Copilot started reviewing on behalf of kbalka October 12, 2026 12:05 View session

Copilot AI reviewed Oct 12, 2026

View reviewed changes

Move checks to common validation

b92501e

kbalka requested a balanced review from Copilot October 12, 2026 13:05

Copilot started reviewing on behalf of kbalka October 12, 2026 13:05 View session

Copilot AI reviewed Oct 12, 2026

View reviewed changes

kbalka requested a balanced review from Copilot October 12, 2026 13:12

Copilot started reviewing on behalf of kbalka October 12, 2026 13:13 View session

Copilot AI reviewed Oct 12, 2026

View reviewed changes

atobiszei reviewed Oct 12, 2026

View reviewed changes

Navigation Menu

Repository navigation

Validate against max resolution before image generation - #4645

Validate against max resolution before image generation#4645
kbalka wants to merge 11 commits into
mainfrom
kbalka_fix_CWE_770_validate_requested_res_vs_max_resolution

kbalka commented Oct 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

atobiszei Oct 12, 2026

Uh oh!

atobiszei Oct 12, 2026

Uh oh!

atobiszei Oct 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kbalka commented Oct 9, 2026

🛠 Summary

🧪 Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

atobiszei Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

atobiszei Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

atobiszei Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants