Skip to content

Stable ABI wheels - #263

Merged
benoit74 merged 1 commit into
mainfrom
abi3
Oct 23, 2026
Merged

benoit74 merged 1 commit into
mainfrom
abi3

Conversation

@rgaudin

@rgaudin rgaudin commented Aug 13, 2026 •

Copy link
Copy Markdown
Member

Fix #264

@rgaudin rgaudin self-assigned this Aug 13, 2026
@codecov

codecov Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.09%. Comparing base (f4c0adb) to head (77f483e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files           1        1           
  Lines         542      542           
=======================================
  Hits          510      510           
  Misses         32       32           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rgaudin rgaudin linked an issue Aug 13, 2026 that may be closed by this pull request
@rgaudin rgaudin mentioned this pull request Aug 13, 2026
@benoit74
benoit74 force-pushed the abi3 branch 3 times, most recently from 9cf002b to d9cf5f8 Compare August 21, 2026 19:51
@benoit74

Copy link
Copy Markdown
Contributor

Looks like I've fixed the thing ; problem was that filename inside the wheel must be libzim.abi3.so on Unix and libzim.pyd on Windows for other Python version to load it correctly ... And it looks like Cython own logic to compute extension filename is buggy on that aspect.

Let's discuss this live next week, because I'm really unsure I got all details correctly

@benoit74

Copy link
Copy Markdown
Contributor

Just updated to latest main commit

@benoit74

Copy link
Copy Markdown
Contributor

@rgaudin CI is green, shall we merge this?

@rgaudin rgaudin left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we use pathlib but yeah it looks good

Comment thread setup.py Outdated
Comment thread .github/workflows/CI-wheels.yaml
A single wheel per platform now covers all supported CPython
versions (excluding free-threaded builds, which cannot use the
limited API).
@benoit74
benoit74 merged commit e6af0b4 into main Oct 23, 2026
72 checks passed
@benoit74
benoit74 deleted the abi3 branch October 23, 2026 18:30
pawank925 pushed a commit to pawank925/python-libzim that referenced this pull request Oct 28, 2026
pawank925 added a commit to pawank925/python-libzim that referenced this pull request Oct 28, 2026
pawank925 added a commit to pawank925/python-libzim that referenced this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build for ABI3

2 participants