Repository navigation
Support multi-archive search and SearchResult with snippets - #276
Sriram-Nambiar wants to merge 1 commit into
Conversation
94e18dd to
f90a269
Compare
benoit74
left a comment
benoit74
left a comment
There was a problem hiding this comment.
We modify the SearchResultSet but this is OK since this will be a major release.
Please:
- mention this breaking change in CHANGELOG
- bump version in
pyproject.tomlto4.0.0-dev0so that we do not release this as a minor by mistake
f90a269 to
c35621f
Compare
|
@Sriram-Nambiar please rebase on main and force push with lease, so that we have tests running on this PR |
c35621f to
61da1b0
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 94.08% 93.09% -1.00%
==========================================
Files 1 1
Lines 541 579 +38
==========================================
+ Hits 509 539 +30
- Misses 32 40 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Please fix QA and try to hit 100% patch code coverage |
73f7e1d to
4a36aef
Compare
| ### Added | ||
|
|
||
| - Add a CI job building the documentation on every PR/push so this kind of breakage is caught automatically (#279) | ||
| - Add support for Python 3.15 (#281) |
There was a problem hiding this comment.
I don't think this PR has anything to do with documentation or Python 3.15 support
There was a problem hiding this comment.
while doing the rebase and resolving the conflict the lines got misplaced by mistake. I have sorted it out now so only the changes related to this PR are included
4a36aef to
47df69c
Compare
Fixes #230 Fixes #226
Support multi-archive searching in Searcher: can be initialized empty, with a list of archives, or populated via add_archive() (also aliased as addArchive()).
search.getResults() yields SearchResult objects exposing archive, path, title, and snippet (instead of just raw path strings).
SearchResult compares equal to str matching its path so existing code and tests expecting entry paths do not break.