Repository navigation
Conversation
The scorecard config is written to the output directory, but the bundle metadata step looked for it in the input directory when --input-dir was set. As a result bundle.Dockerfile and annotations.yaml lacked the scorecard labels and COPY line. Check both directories. Fixes operator-framework#7144 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate bundle --input-dirwrites the scorecard config to the output directory, but the metadata step checked the input directory for it. Sobundle.Dockerfileandannotations.yamlwere generated without the scorecard labels and theCOPY .../tests/scorecardline, andoperator-sdk scorecard <bundle-image>could not find the config.The check now looks in both the input and output directories (new
hasScorecardConfighelper). Piped stdin and the default flow are unchanged.Tested with
go test ./internal/cmd/operator-sdk/generate/bundle/(new unit test for the helper). I did not run the full end-to-endgenerate bundleflow or the e2e suite. Added a changelog fragment.Fixes #7144