Repository navigation
[FSSDK-11170] update: decision service methods for cmab - #583
Merged
Farhan Anjum (FarhanAnjum-opti) merged 60 commits intoNov 17, 2025
Merged
Farhan Anjum (FarhanAnjum-opti) merged 60 commits into
Farhan Anjum (FarhanAnjum-opti) merged 60 commits into
Conversation
…e to support CMAB UUID handling
…and include CMAB UUIDs in responses
…ils for CMAB configuration
…ations over CMAB service decisions in DecisionService
…tly verify error state
…izely and DecisionService
…text and related fetcher classes
Muzahidul Islam (muzahidul-opti)
requested changes
Sep 25, 2025
Muzahidul Islam (muzahidul-opti)
left a comment
Muzahidul Islam (muzahidul-opti)
left a comment
Contributor
There was a problem hiding this comment.
Changes look good to me. Added few comments.
…ecision responses
…ent key retrieval
…eation in CMAB client
…hance decision handling
…ckage-private and add copyright notice to DecisionPath
…and OptimizelyUserContext with corresponding tests
…ndency and adjust related tests
…and enhance builder methods for cache configuration
Jae Kim (jaeopt)
requested changes
Oct 28, 2025
Jae Kim (jaeopt)
left a comment
Jae Kim (jaeopt)
left a comment
Contributor
There was a problem hiding this comment.
I see it's now more aligned with android-sdk. I added more comments. Let's discuss.
|
|
||
| if (decision != null) { | ||
| decisions.add(new DecisionResponse(decision, reasons)); | ||
| decisions.add(new DecisionResponse(decision, reasons, error, decision.cmabUUID)); |
Contributor
There was a problem hiding this comment.
Do we have any case we need pass cmabUUID separately though it's already in decision?
…nService and adjust tests accordingly
…ervice to utilize it
…djust instance creation logic
…on and enhance cache handling logging
Jae Kim (jaeopt)
requested changes
Nov 7, 2025
Jae Kim (jaeopt)
left a comment
Jae Kim (jaeopt)
left a comment
Contributor
There was a problem hiding this comment.
Bucket cleaning up looks good! A few more changes suggested.
…ache size and timeout, and remove CacheWithRemove interface
…in OptimizelyFactory
…in newDefaultInstance method of OptimizelyFactory
Jae Kim (jaeopt)
requested changes
Nov 10, 2025
Jae Kim (jaeopt)
left a comment
Jae Kim (jaeopt)
left a comment
Contributor
There was a problem hiding this comment.
All changes look good to me!
Added a few suggestions - it must be the final round :)
…timizelyDecisionsCallback.java Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
…d add factory method
…dling and backward compatibility
Farhan Anjum (FarhanAnjum-opti)
merged commit Nov 17, 2025
efbda89
into
master
12 of 17 checks passed
Farhan Anjum (FarhanAnjum-opti)
deleted the
farhan-anjum/FSSDK-11170-decision-service-methods-for-cmab
branch
November 17, 2025 05:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decision Service methods to handle CMAB
Test plan
Added unit tests
Issues
FSSDK-11170
FSSDK-12013