Repository navigation
Report a step by a label, the name of its class - #3
Merged
Merged
Conversation
State and Hooks reported each step by the full path of its class (module.QualName). They now report the class name: DiscountFilter. The second use of a class in one pipeline is DiscountFilter#2. A Valve has the label of its Filter. Removed, because they existed only for the full path: - AnonymousStep, and the refusal of classes from a function or from the entry script. A step without the method of its role is refused with a TypeError when it is added. - Pipeline.identities (now Pipeline.labels) and Pipeline.step_sites. - Lint rule CUP-A006 (entry-script step). BREAKING CHANGE: the strings in state.executed, state.skipped, state.errors, state.timings and in Hook calls are class names, not module paths. AnonymousStep, Pipeline.identities and Pipeline.step_sites are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
DiscountFilter. Before, they gave the full path of the class.DiscountFilter#2. A Valve has the label of its Filter.TypeErrorwhen it is added.Removed
AnonymousStep, and the refusal of a class from a function or from the entry script.Pipeline.identities(nowPipeline.labels) andPipeline.step_sites.Not compatible with 1.0.0
The strings in
state.executed,state.skipped,state.errors,state.timingsand in Hook calls change.Checks
Tests on Python 3.9 and 3.12, both linters, the conformance suite, and 2,000 random pipelines.
This pull request is part of a stack. Merge the stack in order, with a merge commit: step-labels, typescript-runtime, typescript-lint, typescript-compile, python-compile-rename, version-2-beta. Each one shows only its own change.
🤖 Generated with Claude Code