Repository navigation
Conversation
1c05809 to
7140833
Compare
Signed-off-by: Martin Mattel <github@diemattels.at>
Signed-off-by: Martin Mattel <github@diemattels.at>
Signed-off-by: Martin Mattel <github@diemattels.at>
Signed-off-by: Martin Mattel <github@diemattels.at>
Signed-off-by: Martin Mattel <github@diemattels.at>
Signed-off-by: Martin Mattel <github@diemattels.at>
Signed-off-by: Martin Mattel <github@diemattels.at>
Signed-off-by: Martin Mattel <github@diemattels.at>
Signed-off-by: Martin Mattel <github@diemattels.at>
- Release notes: add notable change bullets for new/changed CLIs, Collabora deployment example hardening, Spaces image size limit (GRAPH_MAX_IMAGE_FILE_SIZE), EULA removal, and licensing; add "no new deprecations" notice - 9.0 upgrading guide: document Collabora 26.x upgrade (proof key container, enforced admin credentials, new COLLABORA_CONFIG_DIR) and removal of posixfs/owncloudsql storage drivers - 9.0 shared-setup.adoc: add COLLABORA_ADMIN_USER/PASSWORD and COLLABORA_CONFIG_DIR to the deployment example .env section - 9.0 commands.adoc: add offline "Recalculate Space Treesize" and "Reset Password for IDM Users" sections - 9.0 recalculate-treesize.adoc: new standalone page for the offline `ocis storage-users spaces recalculate-treesize` command - 9.0 changed-cli.adoc: document all new/changed CLI commands for the 8.2 → 9.0 delta (recalculate-treesize, resetpassword service users, search --timeout, uploads sessions --orphaned) - 9.0 search.adoc: document --timeout flag; fix --space / mutually exclusive typos (also backported to 8.2 search.adoc) - 9.0 storage-users.adoc: add --orphaned flag to sessions command - 9.0 general-info.adoc: add NOTE about resetting service account passwords (backported to 8.2 general-info.adoc) - 9.0 graph.adoc: add Space Image Size Limit section documenting GRAPH_MAX_IMAGE_FILE_SIZE and its dependency on the thumbnails service (issue #89) - 9.0 thumbnails.adoc: add Input Image File Size Limit section documenting THUMBNAILS_MAX_INPUT_IMAGE_FILE_SIZE (issue #89) - 9.0 EULA removal: remove End-User License Agreement sections from ROOT/index.adoc, admin/index.adoc, and developer/license.adoc; license.adoc now reflects Apache 2.0 only (issue #177) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Martin Mattel <github@diemattels.at>
Add a "Configurable Service Endpoints" section to the gateway developer page describing how each downstream CS3 service endpoint can be overridden with an explicit gRPC URI (dns://, kubernetes://, unix:) instead of relying on service-registry lookups. Includes the per-service env var triple pattern, a unix-socket example for three services, and a note about GRAPH_SPACES_STORAGE_USERS_ADDRESS. Closes #76 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Martin Mattel <github@diemattels.at>
…n, and identity management docs - Document Keycloak as an optional service in the ocis_full ubuntu-compose deployment example (shared-setup.adoc): domain names, .env variables, enable/configure steps, what changes for the admin, and common pitfalls - Add cross-reference note to ocis_keycloak.adoc directing production users to the admin docs instead of the developer-only example - Add identity management overview (index.adoc) with service interaction diagram and built-in vs. external decision table - Add external IAM page (external-iam.adoc) covering LDAP requirements, OIDC provider requirements, user provisioning, AD FS CORS, and a new Access Token Verification section (jwt vs. none, kid header errors, JWKS refresh tuning, audience restriction) - Add KQL search syntax reference page and wire it into the admin nav - Add benchmark CLI command page and wire it into the developer nav - Update architecture, configure-search, search service, and release notes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Martin Mattel <github@diemattels.at>
7e8b8fb to
310cfec
Compare
Injects a one-time navy banner below the navbar informing users about the new Pagefind component/version filter pane. Dismissed state is stored in localStorage so the banner does not reappear. The JS file contains a 3-step removal checklist for when the banner is retired. Also suppresses the navbar hover background shift (navy-deep → navy) so the logo and title area stay visually flat on hover. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Martin Mattel <github@diemattels.at>
…ebuild When ocis_helpers detects a go.mod mismatch at runtime, the required steps are: go mod tidy, go build, then commit go.mod, go.sum, and the binary. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Martin Mattel <github@diemattels.at>
dj4oC
left a comment
There was a problem hiding this comment.
Intent: docs: add ocis 8.2 and 9.0 releasenotes and content
Verdict: REQUEST CHANGES. 0 blocker(s) and 4 should-fix item(s) need addressing before merge; 1 skipped.
| # | Tag | Location | Problem | Suggested fix |
|---|---|---|---|---|
| 1 | SHOULD-FIX | content/ocis/8.2/modules/admin/examples/ocis_helpers/adoc/notifications_configvars.adoc:433 (also ocdav_configvars.adoc:424, sharing_configvars.adoc:712, and all ++8.3.0 ++→++9.0.0 ++ relabels, e.g. activitylog_configvars.adoc:334) |
In the 8.2 documentation tree, variables are labeled as introduced in 9.0.0 — impossible for 8.2 docs. The same PR's own release notes credit these to earlier releases: 8.0.9 lists #13020 (GRPC keepalive, OCDAV toggle, sharing janitor) and #12739, and extended_configvars.adoc carries the comment 'manually added: GRPC PR #13020 (8.2.1 backport)'. A reader of the 8.2 docs is told these options do not exist yet in 8.2, which is wrong. (plausible) |
Label each of these variables with the actual 8.2.x patch release where it landed (e.g. 8.2.1 for the keepalive/instance-mapper vars, per the 8.2.1 notes; the 8.0.9 backports imply presence since 8.2.0) instead of 9.0.0, and regenerate from the 8.2 branch rather than the 9.0 dev line. |
| 2 | SHOULD-FIX | content/ocis/8.2/modules/admin/examples/ocis_helpers/adoc/global_configvars.adoc:2310 (OCIS_OIDC_ISSUER), :3113 (OCIS_URL), :355 (OCIS_CORS_ALLOW_CREDENTIALS), :448 (OCIS_CORS_ALLOW_ORIGINS), :2448 (OCIS_PERSISTENT_STORE) |
The regenerated global table shows signs of being produced from the wrong (9.0 dev) source or a row misalignment: OCIS_OIDC_ISSUER now carries the owncloudsql-IDP description, OCIS_URL is described as 'The public facing URL of WebDAV', and security-relevant defaults changed silently — OCIS_CORS_ALLOW_CREDENTIALS false→true alongside OCIS_CORS_ALLOW_ORIGINS → [*] and OCIS_CORS_ALLOW_METHODS → [GET], plus OCIS_PERSISTENT_STORE default nats-js-kv→memory. Repo rules require that security defaults not weaken silently; none of the 8.2.x release notes in this PR mention a CORS default change. (plausible) |
Re-run the ocis_helpers generation against the oCIS 8.2 branch and diff; restore the correct per-variable descriptions and the pre-change CORS/persistent-store defaults unless an 8.2.x release note in this PR explicitly documents the change. At minimum, revert the OCIS_OIDC_ISSUER and OCIS_URL description cells. |
| 3 | SHOULD-FIX | content/main/modules/ROOT/pages/ocis_release_notes.adoc:100 (9.0.0 Deprecations) and :150 (8.2.3) vs. content/ocis/8.2/modules/admin/examples/ocis_helpers/adoc/auth-basic_configvars.adoc:20 and siblings |
The PR states the drivers were deprecated in 8.2.3 (release notes for 8.2.3 and 9.0.0, PRs #13193/#13302), but every deprecation table in the 8.2 configvars says 'Deprecation Version 8.2.0', and the delta file header was changed to '8.1.0-8.2.3' while the tables say 8.2.0. Three mutually inconsistent version claims in one PR. (plausible) | Pick one deprecation version (the 8.2.3 notes and PR references suggest 8.2.3) and align the configvar deprecation tables, the delta-file header, and the release notes. |
| 4 | SHOULD-FIX | content/ocis/8.2/modules/admin/examples/ocis_helpers/adoc/global_configvars.adoc:448-455 (origins) and :355-362 (credentials), head side |
The 8.2 admin docs regenerated by this PR now document the CORS defaults as allow-origins = * (changed from [https://localhost:9200]) together with allow-credentials = true (changed from false), with no warning text. Browsers reject the literal *+credentials combination, so direct browser exploitation is limited, but the documented default tells every operator running a reflecting reverse proxy in front of oCIS that all origins are allowed with credentials, and it silently weakens a default this repo previously documented as a single localhost origin. Either the product default regressed (raise against ocis) or the generated table mislabels the values — both need to be settled before these docs ship. (plausible) |
Confirm against ocis 8.2/9.0 source (proxy pkg/config/defaults) whether OCIS_CORS_ALLOW_ORIGINS really defaults to [*] and OCIS_CORS_ALLOW_CREDENTIALS to true. If yes, the docs must carry an explicit warning in the CORS chapter and the product default should be tightened; if the generator misaligned rows, regenerate the table so the defaults shown are the real ones. Do not publish 8.2 docs stating wildcard-origins+credentials as the safe default. |
| 5 | NIT | content/main/modules/ROOT/pages/ocis_release_notes.adoc:256 |
Introduced typo: 'added .See' — space before the period. The underlying fix (replacing the unfinished 'For details see the ...' with a real xref) is good. | Change to 'New environment variables have been added. See the xref:...'. |
| 6 | NIT | content/ocis/8.2/modules/admin/examples/ocis_helpers/adoc/graph_configvars.adoc:1359 (also notifications_configvars.adoc:426) |
Unit mismatch: the description says 'seconds' but the default 60000000000 is a Go Duration in nanoseconds (= 60 s, as the 8.2.1 release note correctly states 'default 60s'). Same pattern for OCIS_GRPC_MAX_RECEIVED_MESSAGE_SIZE: default cell 0 while the description says 'Defaults to 10240000 bytes (10MB)'. |
Describe the value as a duration/nanoseconds ('Max TTL for the LDAP instance mapper cache, as a duration in ns; 60000000000 = 60s') and clarify that 0 for the grpc message size means 'use the 10 MB library default'. |
| 7 | NIT | content/ocis/8.2/modules/admin/examples/ocis_helpers/env_var_deltas/8.1.0-8.2.0-deprecated.adoc:2 |
The header comment now says '8.1.0 and 8.2.3' but the filename is still 8.1.0-8.2.0-deprecated.adoc; the include site presumably references the filename, so the two disagree. |
Either rename the file to 8.1.0-8.2.3-deprecated.adoc (and update its include) or keep the header at 8.2.0 and add a separate 8.2.2-8.2.3 delta file for the driver deprecations. |
| 8 | NIT | content/AGENTS.md:31; README.md:158 |
Scope discipline: a repo-convention/guideline addition (xref fragment format rules for all authors) and a README version-table edit labeling 9.0 as '(dev)' while the same PR publishes 9.0.0 as a Production release are unrelated to 'add 8.2/9.0 release notes'. The AGENTS.md change belongs in its own PR; the README '(dev)' label should be reconciled with the post-publication state (drop prerelease) in the follow-up PR the description mentions. (plausible) |
Move the AGENTS.md section to a separate PR; in README either drop '(dev)' for 9.0 if the folder is un-prereleased at merge time, or add a note that the label flips in the post-9.0-publication PR. |
| 9 | NIT | content/ocis/8.2/modules/admin/examples/ocis_helpers/adoc/global_configvars.adoc:1853-1860 (and :1774-1780, :1392-1398), head side |
The 8.2 docs now state changed defaults for authentication-relevant LDAP schema attributes (username attribute displayName→uid, plus case changes on displayname and ownCloudUUID). LDAP attribute names are case-sensitive, so an operator whose directory only matches the old casing can hit login/lookup failures after following these docs; neither the 8.2.0 release notes in this same PR nor the upgrading page calls out this default change. (plausible) | Verify the defaults against ocis 8.2 source; if the change is real, add a line to the 8.2.0 release notes / upgrading-ocis.adoc calling out the new LDAP username/ID attribute defaults so operators can pre-check their directory schema. |
Tests: This is a docs-only PR; the repo has no unit tests for AsciiDoc content, so the effective verification is the Antora build plus npm test (extension-tests, including xref/static-file checks) — CI is green per the gates, which covers build success. What is NOT covered: (1) the mechanical rename of the deprecation anchor across ~50 generated files — a single missed `deprecation-note-2026-09-09-11-3 / Gates report CI green (1 skipped) and the Antora build passing, which exercises the renamed deprecation anchor (deprecation-note-2026-09-09-11-30-54 → -2026-11-13-09-58-28) across ~45 configvar files — broken xrefs would fail/warn the build, so the rename looks consistent. However, the PR's headline feature — the search refinement by component and version (Pagefind UI filters, presumably under ui/
Security (changed surface): 2 security finding(s) — see table; A05:2021 Security Misconfiguration; CWE-942 (Permissive Cross-domain Policy with Untrusted Origins) on the first
OSPO / compliance: License AGPL-3.0 · REUSE ok (light check) · Signed commits ok · DCO ok · New deps none · PR title ok
CI: 1 skipped
Review scope
Reviewed 1bf596f480…b917b1584a (100 files). Lenses: A, B. Tools: GitHub REST (diff, checks, commits, advisories), secrets regex scan; no clone, no reuse lint. Not covered: The component/version search-refinement feature claimed in the PR description — the relevant files (likely ui/supplemental Pagefind JS and possibly antora-extensions) are beyond the truncated 100-file diff, so I cannot judge its correctness or whether extension-tests cover it., Whether content/ocis/9.0/ (antora.yml prerelease flags, developer docs migration) is internally consistent with the README '9.0 (dev)' label and the 9.0.0 '(Production)' release-note heading — those files are not in the provided diff., Whether any of the ~50+ configvar files outside the shown hunks still reference the old deprecation anchor ID deprecation-note-2026-09-09-11-30-54., The component/version search-refinement implementation (likely ui/supplemental JS): not visible in the truncated diff; cannot assess XSS via filter rendering (CWE-79), URL-parameter handling, or whether filters leak content from prerelease versions into search results., The new content/ocis/9.0/ tree (admin + migrated developer docs from owncloud.dev): not visible; cannot check for embedded credentials, third-party code samples with incompatible licenses, or REUSE annotations beyond the light gate check (G3)., Whether the newly documented CORS defaults (*, credentials=true) match the actual ocis 8.2/9.0 product code — that lives in the ocis repo, not this one.; parts of the diff beyond the size cap; files beyond the first 100.
AI-assisted review: drafted by Mistral AI (mistral-large-latest) using the Superpowers code-review protocol for dj4oC, who remains accountable for it. If you disagree with a point, reply in its thread.
🤖 Generated with Mistral AI
| * Added a new space membership role: `Can edit`. | ||
|
|
||
| * The new environment variables have been added. For details see the ... | ||
| * New environment variables have been added .See the xref:ocis:admin:migration/upgrading-ocis.adoc[Migration and Upgrade, window=_blank] section of the Infinite Scale admin documentation for more details. |
There was a problem hiding this comment.
NIT — Introduced typo: 'added .See' — space before the period. The underlying fix (replacing the unfinished 'For details see the ...' with a real xref) is good.
Fix: Change to 'New environment variables have been added. See the xref:...'.
| @@ -1,7 +1,7 @@ | |||
| // # Deprecated Variables between oCIS 8.1.0 and oCIS 8.2.0 | |||
| // # Deprecated Variables between oCIS 8.1.0 and oCIS 8.2.3 | |||
| // commenting the headline to make it better includable | |||
There was a problem hiding this comment.
NIT — The header comment now says '8.1.0 and 8.2.3' but the filename is still 8.1.0-8.2.0-deprecated.adoc; the include site presumably references the filename, so the two disagree.
Fix: Either rename the file to 8.1.0-8.2.3-deprecated.adoc (and update its include) or keep the header at 8.2.0 and add a separate 8.2.2-8.2.3 delta file for the driver deprecations.
This PR adds all changes and release notes for ocis 8.2 and 9.0.
It also adds a new search capabillity to refine for component and version.
Release notes have been added for the missing patch releases too.
This PR DOES NOT create a new 9.1 (pre) version or phases out 8.1. This must be done in a separate PR AFTER merging this one.
This PR MUST NOT be merged before ocis 9.0 has been published !