Repository navigation
Count ICMP-needed drops from L3Router - #406
Open
FelixMcFelix wants to merge 1 commit into
Open
FelixMcFelix wants to merge 1 commit into
FelixMcFelix wants to merge 1 commit into
Conversation
FelixMcFelix
added this pull request to stack #407
October 16, 2026 11:35
FelixMcFelix
marked this pull request as ready for review
October 16, 2026 11:37
Packets which are dropped in L3Router and its nested controls all need to be handled by the host, so we cannot actually drop these packets in the Tofino. However the counters were only ever modified when the packet is truly dropped, so these counters were non-functional. This PR separates out the counter increment to occur for both classes of drop. I did look into centralising everything onto `ig_dprsr_md.drop_ctl` and ridding ourselves of `meta.dropped`, but this ended up both uglier and took up more stages under multicast. Simple seems best, here! Fixes #404.
FelixMcFelix
force-pushed
the
felixmcfelix/fix-404
branch
from
October 20, 2026 12:59
21e3553 to
c406851
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packets which are dropped in L3Router and its nested controls all need to be handled by the host, so we cannot actually drop these packets in the Tofino. However the counters were only ever modified when the packet is truly dropped, so these counters were non-functional. This PR separates out the counter increment to occur for both classes of drop.
I did look into centralising everything onto
ig_dprsr_md.drop_ctland ridding ourselves ofmeta.dropped, but this ended up both uglier and took up more stages under multicast. Simple seems best, here!Fixes #404.