Repository navigation
[p4rs, codegen] Pipeline::clear_table_entries, + helios CI bump - #278
Open
zeeshanlakhani wants to merge 1 commit into
Open
zeeshanlakhani wants to merge 1 commit into
zeeshanlakhani wants to merge 1 commit into
Conversation
When dpd restarts against a running softnpu pipeline, previous table entries persist, even though the daemon does not know what the keys are. `Pipeline` had support for add/remove by key and a dump command, but there was no generic way to empty tables. This work adds a `clear_table_entries(table_id)` to the trait. In codegen, we now emit a `clear_<qtfn>_entries` per table alongside the add/remove/get ones. With this change in place, softnpu can use it for a write-only `TableClear` management message, so that dendrite's SoftNPU `TableOps::clear` can be un-stubbed. Includes: - [ci] s/helios-2.0/helios-3.0/ matching other networking repos.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dpd restarts against a running softnpu pipeline, previous table entries persist, even though the daemon does not know what the keys are.
Pipelinehad support for add/remove by key and a dump command, but there was no generic way to empty tables.This work adds a
clear_table_entries(table_id)to the trait. In codegen, we now emit aclear_<qtfn>_entriesper table alongside the add/remove/get ones.With this change in place, softnpu can use it for a write-only
TableClearmanagement message, so that dendrite's SoftNPUTableOps::clearcan be un-stubbed.Includes: