Repository navigation
feat(preview): pass an optional npm read token to preview image builds - #157
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The preview-build authentication change has no active review issues.
No open issues 🎉
What changed in this PR
Enables preview image builds to authenticate with GitHub Packages, using the same secret interface as production builds.
Changes:
- Adds the optional
npmGithubReadTokenworkflow secret. - Passes it to Docker builds as the BuildKit secret
npm_github_token, allowing Containerfiles to access private npm packages.
| File | Description |
|---|---|
.github/workflows/preview.build-image.yaml |
Declares the optional npm read token and forwards it to the Docker build. |
Review effort: Balanced
jmpalomares
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: BE-2928
What
preview.build-image.yamlgets an optionalnpmGithubReadTokensecret, the same namebuild-image.yamluses. It reaches the Docker build as the BuildKit secretnpm_github_token.Why
product-api now installs
@parcellab/siftfrom GitHub Packages during the image build (parcelLab/product-api#9554). The Containerfile reads the token from/run/secrets/npm_github_token. Production builds get it throughbuild-image.yaml, but preview builds had no way to pass it, so they fail withcat: can't open '/run/secrets/npm_github_token'(run).The secret is optional. Callers that don't pass it get an empty
npm_github_tokensecret, which their Containerfiles never mount, so nothing changes for them.