Repository navigation
test(sync): stop the disconnect-lock test racing its own log - #181
Merged
Merged
Conversation
runWhileNoSyncRuns_waitsForTheSyncInFlightToFinish recorded "sync finished" after the sync had already let go of the lock, so the wipe could log "cleared" first and the in-order check failed now and then. It stopped the 2.7.56 release build once. The test now checks what the lock guarantees: the wipe runs only after the sync has applied its snapshot, and both entries are there, in either order. Refs: #170
Test coverage (unit + instrumentation)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes
SyncServiceTest.runWhileNoSyncRuns_waitsForTheSyncInFlightToFinishdeterministic. The test now checks what the lock guarantees: the wipe runs only after the sync has applied its snapshot, and both log entries are present, in either order.Why
The test recorded "sync finished" after the sync had already released the lock, so "cleared" could land first and the in-order assertion failed now and then. It stopped the 2.7.56 release build once; a rerun passed. The production code was right; the test raced its own log.
Testing
./gradlew :app:testDebugUnitTest --tests "*SyncServiceTest" --rerun5 times in a row: all pass../gradlew :app:spotlessCheck: pass.References
#170