Repository navigation
Add PyBaMM 26.9 support - #21
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Dependency bounds, CI coverage, and test documentation are consistent with the stated support policy.
Review effort: Balanced
Findings: None
What changed in this PR
Adds PyBaMM 26.9 support while adopting a rolling six-release compatibility window.
Changes:
- Supports PyBaMM 26.4–26.9.
- Updates CI coverage and related test documentation.
- Documents the dependency support policy.
| File | Description |
|---|---|
pyproject.toml |
Updates dependency bounds and policy. |
.github/workflows/test.yml |
Tests all six supported releases. |
tests/cells/test_lead_acid.py |
Updates supported-version commentary. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PyBaMM apparently switched form quarterly to monthly releases, also limit the support window (i.e. checked in CI) to the last 6 releases.