Repository navigation
Handle null GIF input with IOException - #2217
Merged
Merged
Conversation
Owner
|
Thank you for the PR. Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GifFilterRender.setGifacceptsInputStream?, butGifStreamObject.loadimmediately callsavailable()on it. Passing null therefore raises an unexpectedNullPointerExceptionbefore GIF decoding starts.Change
Reject null at the start of
GifStreamObject.loadwithIOException, using the existing GIF loading error path. This preserves the Kotlin nullable parameter and existing JVM method signatures.Add
GifFilterRenderTest.nullInputIsReportedAsIoExceptionto exercise the public Kotlin API. It fails with NPE on the original code and passes after this fix.Validation
With only this change applied to base commit
82a9cb4ee4babdc792d2ccee8b893f2b36207d40, using Gradle 9.7.1 and JDK 17:common: 98 tests passed.encoder: 26 tests passed.git diff --checkpassed.A supplementary JVM check also loaded a valid one-frame 1×1 GIF using the real decoder before and after the fix. That check uses an in-memory Android Bitmap stand-in; device rendering was not tested.
Fixes #2216