Repository navigation
Reject stream URLs without a scheme during URL validation - #2219
Merged
Merged
Conversation
Owner
|
Thank you for the PR. Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
UrlParser.parse("//localhost/live/test", arrayOf("rtmp"))passes host/path validation but throwsNullPointerExceptionwhen the null scheme is assigned to a non-null Kotlin property.The streaming clients catch
URISyntaxExceptionduring URL validation, so this input bypasses their malformed-endpoint handling.Change
Reject a missing scheme along with unsupported schemes using the existing
URISyntaxExceptionpath.Add two regression cases to
UrlParserTest: a scheme-less hostname URL and a scheme-less IPv4 URL with an explicit port. Both fail with NPE before the fix and pass afterward.Validation
With only this change applied to base commit
82a9cb4ee4babdc792d2ccee8b893f2b36207d40, using Gradle 9.7.1 and JDK 17:common: 100 tests passed, including the existing URL parsing tests.encoder: 25 tests passed.git diff --checkpassed.Fixes #2218