Skip to content

chore: Remove the monitor and make it optional in the test harness - #588

Merged
ebma merged 4 commits into
mainfrom
chore/move-monitor
Oct 26, 2026
Merged

ebma merged 4 commits into
mainfrom
chore/move-monitor

Conversation

@ebma

@ebma ebma commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

What changes

  • The monitor is maintained separately and is removed from this repository (monitor/).
  • The end-to-end harness (testing/) treats the monitor as optional:
    • MONITOR_DIR (absolute, or relative to the current directory) points at a built monitor checkout. When it is set, the harness starts the monitor from there, clears its state file and runs the monitor checks as before.
    • When it is unset, the run says that it runs without the monitor, runs everything else, and lists the monitor-only checks as skipped in the summary.
    • Checks that cover other components and also confirmed that the monitor was running keep their other assertions.
    • This applies to phase 3 (phase3-e2e.mjs), the phase 5 rehearsal and the phase 6 drills.
  • harness.mjs gains skip(); the summary shows skipped checks separately.
  • migration-tests.yml no longer has a monitor path filter or a monitor entry in the daemons matrix.
  • testing/README.md and docs/pen-migration-local-test-plan.md point to MONITOR_DIR instead of monitor/, and phase 3 starts Anvil with immediate finality.
  • Phase 3's approval check now covers both steps of the monitor's handling of fabricated approvals: the first is reported with the vault still running, a second one from another attestor pauses the vault.

Including the monitor in end-to-end runs

# in the monitor checkout
npm install && npm run build
# in this repository, with Chopsticks on :8000 and Anvil on :8545
MONITOR_DIR=/path/to/monitor node testing/src/phase3-e2e.mjs

Without MONITOR_DIR, the same command runs without the monitor.

Testing

  • npm test in attestor/ (86 pass) and releaser/ (22 pass).
  • actionlint on the changed workflow; node --check on every harness script.
  • Phase 3 on Chopsticks and Anvil (--slots-in-an-epoch 0): without MONITOR_DIR, 6/6 pass and the 3 monitor checks are listed as skipped; with it, 9/9 pass.

ebma added 4 commits October 26, 2026 10:28
The end-to-end harness starts the monitor from MONITOR_DIR and makes the
monitor checks only then. Without it, runs print that they are without the
monitor, skip the monitor-only checks and report them as skipped.
The monitor is maintained separately. Drop it from the migration-tests
workflow and point the testing docs at MONITOR_DIR for end-to-end runs.
@ebma
ebma merged commit e9d4a87 into main Oct 26, 2026
6 checks passed
@ebma
ebma deleted the chore/move-monitor branch October 26, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant