Repository navigation
chore: Remove the monitor and make it optional in the test harness - #588
Merged
Merged
Conversation
The end-to-end harness starts the monitor from MONITOR_DIR and makes the monitor checks only then. Without it, runs print that they are without the monitor, skip the monitor-only checks and report them as skipped.
The monitor is maintained separately. Drop it from the migration-tests workflow and point the testing docs at MONITOR_DIR for end-to-end runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
monitor/).testing/) treats the monitor as optional:MONITOR_DIR(absolute, or relative to the current directory) points at a built monitor checkout. When it is set, the harness starts the monitor from there, clears its state file and runs the monitor checks as before.phase3-e2e.mjs), the phase 5 rehearsal and the phase 6 drills.harness.mjsgainsskip(); the summary shows skipped checks separately.migration-tests.ymlno longer has a monitor path filter or a monitor entry in the daemons matrix.testing/README.mdanddocs/pen-migration-local-test-plan.mdpoint toMONITOR_DIRinstead ofmonitor/, and phase 3 starts Anvil with immediate finality.Including the monitor in end-to-end runs
Without
MONITOR_DIR, the same command runs without the monitor.Testing
npm testinattestor/(86 pass) andreleaser/(22 pass).actionlinton the changed workflow;node --checkon every harness script.--slots-in-an-epoch 0): withoutMONITOR_DIR, 6/6 pass and the 3 monitor checks are listed as skipped; with it, 9/9 pass.